fix: use new shape for image() #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Princesseuh
added
the
merge-on-release
yanthomasdev
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Love the change, nice work @Princesseuh, Astro PR not merged yet but LGTM!
|
Just adding that since our (stable) content collections page already doesn't show a schema using assets, I don't think this change requires us to update anywhere else. The only other page to keep consistent with this one is the Image Service API reference page. So if there's no change also required there, then this is fine to docs! |
sarah11918
approved these changes
Apr 3, 2023
sarah11918
added
the
improve documentation
sarah11918
added
the
minor-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
withastro/astro#6703 changes the shape of
image()to come fromschemainstead. The underlying technical reasons are highlighted in the PR