Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro Actions #8980

Merged
merged 68 commits into from
Aug 28, 2024
Merged

Astro Actions #8980

merged 68 commits into from
Aug 28, 2024

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Aug 1, 2024

Description (required)

  • Add new guide page for Astro Actions
  • Add new API reference section for Actions
  • TODO: Updates to React integration docs for React 19 + actions
  • TODO: Updates to form submission recipe to recommend actions

Related issues & labels (optional)

For Astro version: 4.15. Experimental baseline PR still TODO

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 3eeeeef
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66ce3ae33d3d5d0008c545c8
😎 Deploy Preview https://deploy-preview-8980--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bholmesdev bholmesdev requested a review from delucis August 1, 2024 22:28
@bholmesdev bholmesdev marked this pull request as draft August 1, 2024 22:29
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 1, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/actions.mdx Source added, will be tracked.
en reference/api-reference.mdx Source changed, localizations will be marked as outdated.
en nav.ts Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Aug 5, 2024
@sarah11918 sarah11918 added this to the 4.14 milestone Aug 5, 2024
bholmesdev and others added 7 commits August 26, 2024 15:55
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay Ben! Ignore these, they're for Chris!

Some polishing on the actions guide page. Will perform surgery moving the API reference stuff around and in the right place, mirroring with context etc.

src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/actions.mdx Outdated Show resolved Hide resolved
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay Ben! Ignore these, they're for Chris!

Some polishing on the actions guide page. Will perform surgery moving the API reference stuff around and in the right place, mirroring with context etc.

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@sarah11918 sarah11918 changed the base branch from main to 4.15.0 August 27, 2024 21:45
@sarah11918
Copy link
Member

OK, this one's ready for polish, @yanthomasdev and whoever else might be watching! 😄

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Aug 27, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bholmesdev , and @delucis for your massive efforts here!

I'm approving as the "final form" of these docs, and the PR will stay open on Wednesday for Yan or anyone else to spot things or make any last minute changes.

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a silly comma nit, this is looking great!

src/content/docs/en/reference/api-reference.mdx Outdated Show resolved Hide resolved
bholmesdev and others added 2 commits August 28, 2024 16:13
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@sarah11918
Copy link
Member

!coauthor

Copy link

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Chris Swithinbank <357379+delucis@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>

@sarah11918 sarah11918 merged commit 1d973dc into 4.15.0 Aug 28, 2024
1 check passed
@sarah11918 sarah11918 deleted the feat/actions branch August 28, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants