-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(zh-CN): update components
#1591
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your update. @Muzych I left a little modification suggestion
Thank you @Muzych One thing I forgot to point out is that in the documentation, we don't recommend using words like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No vague sentences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make text more concise and clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now. Thank you for your patience. Welcome to the Starlight contributors. @Muzych
Thanks for your patience too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the translation 🙌
If I'm not mistaken, I think this may be missing the changes from https://github.com/withastro/starlight/pull/1568/files#diff-bde0eef3b5aa6eb8762ac30b4992c55505bc9eb0373f4a05d81f58f39c05e3bd
Would you be able to add the changes from that PR to this translation?
|
||
<FileTree> | ||
|
||
- astro.config.mjs an **important** file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment an **important** file
can be safely translated. Would it make sense to do so?
I'll let you decide as you definitely know the best but if yes, the example below should also be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense, thank you for the advice, I will deal with these issues.
No worries at all. If you still have the changes locally, for sanity, I would start by copying that file somewhere else just in case (if not, the changes are still available here). I guess I would also try to disable the app, at least for this repository, to avoid this happening again. I personally don't use it so no idea how it works. Then, you should be able to just push a new commit with your previous changes and it should update the PR. If you need more help or want me to do it for you, just let me know. |
Ok, I 'll push previous changes again. |
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything is in order now. Thanks for your patience, this was quite the ride but this is looking great now. 🌟
Thanks again for your contribution 🙌
Description
Updates
components