Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(zh-CN): update components #1591

Merged
merged 2 commits into from
Mar 10, 2024
Merged

i18n(zh-CN): update components #1591

merged 2 commits into from
Mar 10, 2024

Conversation

Muzych
Copy link
Contributor

@Muzych Muzych commented Mar 3, 2024

Description

  • Closes # N/A
  • What does this PR change? Give us a brief description.
    Updates components

Copy link

changeset-bot bot commented Mar 3, 2024

⚠️ No Changeset found

Latest commit: 6bc9259

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 10, 2024 2:51am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Mar 3, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update. @Muzych I left a little modification suggestion

@liruifengv
Copy link
Member

Thank you @Muzych

One thing I forgot to point out is that in the documentation, we don't recommend using words like we or 我们. You can find some suggestions in the Writing Style Guide.

Do not use we, we’ll, us, let’s etc. (You are not with the reader.)

Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No vague sentences

Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make text more concise and clear

Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now. Thank you for your patience. Welcome to the Starlight contributors. @Muzych

@Muzych
Copy link
Contributor Author

Muzych commented Mar 4, 2024

Looks great now. Thank you for your patience. Welcome to the Starlight contributors. @Muzych

Thanks for your patience too.

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the translation 🙌

If I'm not mistaken, I think this may be missing the changes from https://github.com/withastro/starlight/pull/1568/files#diff-bde0eef3b5aa6eb8762ac30b4992c55505bc9eb0373f4a05d81f58f39c05e3bd
Would you be able to add the changes from that PR to this translation?


<FileTree>

- astro.config.mjs an **important** file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment an **important** file can be safely translated. Would it make sense to do so?

I'll let you decide as you definitely know the best but if yes, the example below should also be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense, thank you for the advice, I will deal with these issues.

@HiDeoo
Copy link
Member

HiDeoo commented Mar 8, 2024

Hmm, looks like this PR is now empty after this app (I guess something installed on your end @Muzych ?) force-pushed some changes 🤔

@Muzych
Copy link
Contributor Author

Muzych commented Mar 8, 2024

Hmm, looks like this PR is now empty after this app (I guess something installed on your end @Muzych ?) force-pushed some changes 🤔

I don't know how to deal with this situation, maybe I 'll open another pull request? I didn't realize that this app would have such a big impact on other projects.

@HiDeoo
Copy link
Member

HiDeoo commented Mar 8, 2024

I don't know how to deal with this situation, maybe I 'll open another pull request? I didn't realize that this app would have such a big impact on other projects.

No worries at all. If you still have the changes locally, for sanity, I would start by copying that file somewhere else just in case (if not, the changes are still available here).

I guess I would also try to disable the app, at least for this repository, to avoid this happening again. I personally don't use it so no idea how it works.

Then, you should be able to just push a new commit with your previous changes and it should update the PR.

If you need more help or want me to do it for you, just let me know.

@Muzych
Copy link
Contributor Author

Muzych commented Mar 9, 2024

I don't know how to deal with this situation, maybe I 'll open another pull request? I didn't realize that this app would have such a big impact on other projects.

No worries at all. If you still have the changes locally, for sanity, I would start by copying that file somewhere else just in case (if not, the changes are still available here).

I guess I would also try to disable the app, at least for this repository, to avoid this happening again. I personally don't use it so no idea how it works.

Then, you should be able to just push a new commit with your previous changes and it should update the PR.

If you need more help or want me to do it for you, just let me know.

Ok, I 'll push previous changes again.

Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything is in order now. Thanks for your patience, this was quite the ride but this is looking great now. 🌟

Thanks again for your contribution 🙌

@HiDeoo HiDeoo merged commit 0d49204 into withastro:main Mar 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants