Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back printing of device logs location #1110

Closed
Niryo opened this issue Jan 7, 2019 · 17 comments
Closed

Bring back printing of device logs location #1110

Niryo opened this issue Jan 7, 2019 · 17 comments

Comments

@Niryo
Copy link
Contributor

Niryo commented Jan 7, 2019

Description

In previous versions of detox, on every successful installation on the device, detox was printing the location of the device's log (line 10):
image 2

On the newer version of Detox, we cannot see the location of the device log unless we turn on loglevel verbose or loglevel trace, but then the logs contain too much information for day to day usage:
image 3

Please bring back the logs to the standard loglevel, it was very useful and made life easier.
Thanks!

@noomorph
Copy link
Collaborator

noomorph commented Jan 7, 2019

What do you think if you could have used Detox log artifacts? Or there's something unusable in your case about it?

@Niryo
Copy link
Contributor Author

Niryo commented Jan 7, 2019

can you explain?

@noomorph
Copy link
Collaborator

noomorph commented Jan 8, 2019

@Niryo
Copy link
Contributor Author

Niryo commented Jan 23, 2019

Without going deeply into that solution, I think it's an overkill for what I am asking for. I just want the path to the device logs so I could read them in my terminal. It was a very convenient feature of old detox versions- just copy the path, paste it in the terminal and see the logs. no boilerplate.

@noomorph
Copy link
Collaborator

Okay, I see.

@rotemmiz, in general, do you mind if we return the former behavior back where it was?

@rotemmiz
Copy link
Member

We should probably stop using that and start using xcrun simctl spawn booted log stream --level=info --predicate {somePredicate} instead

@rotemmiz
Copy link
Member

But to answer your question, sure, why not.

@LeoNatan
Copy link
Contributor

We should be using the new log system.

@LeoNatan
Copy link
Contributor

And so can @Niryo to get his log

@rotemmiz
Copy link
Member

@LeoNatan what do you mean? xcrun simctl spawn {deviceudid} log ?

@LeoNatan
Copy link
Contributor

LeoNatan commented Jan 23, 2019

Yes. In the case @Niryo, he can limit his log output using that command to only his app, which is preferable for him.

In the case of Detox, we shouldn't use any predicate but collect everything.

@Niryo
Copy link
Contributor Author

Niryo commented Jan 23, 2019

the problem is not limiting the log output, but locating the device logs. look at the first picture, back at the good old days, detox was printing the location of the device logs and it was very convenient.
But maybe I got your answer wrong.

@LeoNatan
Copy link
Contributor

You are missing the point. You don't need to locate anything. Using the new log command, you can get the output of your app's log to just stream in your terminal.

@LeoNatan
Copy link
Contributor

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
@Niryo Niryo reopened this Sep 8, 2019
@Niryo
Copy link
Contributor Author

Niryo commented Sep 8, 2019

@noomorph hi, this issue has been fixed in detox 13, but now it looks like the logs are gone again (in 14)

@LeoNatan
Copy link
Contributor

LeoNatan commented Sep 8, 2019

What do you mean @Niryo ? The command to print logs is no longer printed?

@LeoNatan LeoNatan closed this as completed Sep 8, 2019
@LeoNatan
Copy link
Contributor

LeoNatan commented Sep 8, 2019

Please don't reopen old issues. Open a new one and provide a description of the problem as it exists today. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants