Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what's the best way to match tabs in iOS? #12

Closed
talkol opened this issue Aug 3, 2016 · 4 comments
Closed

what's the best way to match tabs in iOS? #12

talkol opened this issue Aug 3, 2016 · 4 comments
Assignees
@DanielZlotin
Labels
status: accepted status: discussion

Comments

@talkol
Copy link

talkol commented Aug 3, 2016

requires some research

what's the best way to match the different tab icons?

need to add this to the api
@talkol
Copy link
Author

talkol commented Oct 11, 2016

we need support for assigning accessibilityID as a prop named testID (like the rest of React Native naming convention) to all components supported in react-native-navigation like nav buttons and tabs.

@LeoNatan
Copy link
Contributor

LeoNatan commented Apr 4, 2017

@DanielZlotin Make sure to add support for testID in navigation v2. UITabBarItem supports accessibility identifiers. This is a navigation issue.

@LeoNatan LeoNatan closed this as completed Apr 4, 2017
@DanielZlotin DanielZlotin mentioned this issue Apr 4, 2017
Closed
@DanielZlotin
Copy link
Contributor

DanielZlotin commented Apr 4, 2017 •
edited
Loading

will do, although title bar item in iOS is a problem...

@LeoNatan
Copy link
Contributor

LeoNatan commented Apr 4, 2017

Let's discuss the title bar some more. I am not convinced yet how to solve properly.

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DanielZlotin DanielZlotin

Labels
status: accepted status: discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@LeoNatan @DanielZlotin @talkol @d4vidi