-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this work with Expo? #147
Comments
It should, @brentvatne tried it already and approved :) |
@rotemmiz Should we name this explicitly in the docs maybe? It is a feature compared to other tools, AFAIK |
Yes I would list this in the react native docs. Expo is fairly widely used.
On 1 Jun 2017 09:22, "Daniel Schmidt" <notifications@github.com> wrote:
@rotemmiz <https://github.com/rotemmiz> Should we name this explicitly in
the docs maybe? It is a feature compared to other tools, AFAIK
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#147 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC8oX36IHGh4shF7AtFf-30e7g1prpHuks5r_li3gaJpZM4NsGNK>
.
|
Sorry, how do we use this with Expo? Since expo doesn't have the ios folder. What do we put in the binaryPath in the configuration? |
@brentvatne , can you please elaborate about your experience with Detox on Expo, do you have an example project that we can take a look on maybe ? |
sure thing, I'll make an example project and share it. @hewrin - you need to use the .app and .apk from the |
Hello @brentvatne, // into package.json
"detox": {
"configurations": {
"ios.sim.debug": {
"binaryPath": "e2e/Exponent-1.16.2.app",
"build": "",
"type": "ios.simulator",
"name": "iPhone 7"
}
}
}
// The e2e test
describe('e2e', () => {
before(async () => {
await device.relaunchApp({ url: 'exp://localhost:19000' })
})
it('should have login screen', async () => {
// await device.reloadReactNative()
await expect(element(by.label('Got it'))).toBeVisible()
await element(by.label('Got it')).tap()
await expect(element(by.id('login'))).toBeVisible() // testID="login" in landing page
})
}) Are you getting things working on your side? |
@xcarpentier - you can skip this if you set |
Would be great if someone could to the example repo. Going to test this out too soon |
Thank you! @brentvatne @elie222 I found a way to not showing this screen: I can see the first screen of my app, but the new issue I have is that I have a webview for the login (using keycloak). |
@xcarpentier I thought this screen is visible only in developer mode, isn't it? If yes, you just need to build the Release build for iPhone Simulator and test the application without problems. |
let's move discussions about expo/detox here, so we don't spam detox people: expo/expo#424 if we run into any bugs we can file specific issues for that outside of this issue. |
@brentvatne yes, stop intox detox please 😂 |
Sorry if this has been posted. Not sure how I can search issues on my mobile and haven't seen it while scrolling through.
The text was updated successfully, but these errors were encountered: