Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocha 4.0.0 doesn't exit after running tests #398

Closed
maartenschumacher opened this issue Nov 10, 2017 · 3 comments
Closed

Mocha 4.0.0 doesn't exit after running tests #398

maartenschumacher opened this issue Nov 10, 2017 · 3 comments

Comments

@maartenschumacher
Copy link

maartenschumacher commented Nov 10, 2017

Description

While following the Getting Started guide I pulled the latest version of Mocha, which doesn't exit the process after completing the tests (https://github.com/mochajs/mocha/releases/tag/v4.0.0, you can revert to the old behavior by passing a --exit flag to the mocha run command). However it took me a while to realize this and thought something was wrong with detox. I had to run the example project to finally understand I had a newer version of mocha.

Maybe you should migrate to the new mocha version, passing the --exit flag in the default mocha.opts? Or declare a peer dependency of mocha 3? Not sure about the best way to handle this.

Steps to Reproduce

Upgrade mocha to the latest version in the example project and run the tests; it seems to just hang after completing the tests.

Detox, Node, Device, Xcode and macOS Versions

  • Detox: 5.9.3
  • Node: 8.7.0
  • Device: iPhone 7 Plus, iOS 11.1
  • Xcode: 9.1
  • macOS: 10.13

Device and verbose Detox logs

na

@LeoNatan
Copy link
Contributor

This is a duplicate of another issue. Please use the search function before opening new issues.

@ChrisGrigg
Copy link

What's the duplicate? Care to share a link?

@rotemmiz
Copy link
Member

It was fixed about two months ago, use Detox 6.x.x for latest fixes and features. And read the release notes for breaking changes.

#368

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants