Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detox 7 #507

Closed
matyj opened this issue Jan 10, 2018 · 8 comments
Closed

detox 7 #507

matyj opened this issue Jan 10, 2018 · 8 comments

Comments

@matyj
Copy link

matyj commented Jan 10, 2018

How do we install detox 7 by npm? Current version is still 6.0.4, but docs says that version 7 has support for Android Studio 3.0.

@fdnhkj
Copy link
Contributor

fdnhkj commented Jan 10, 2018

Any ETA of detox 7 ? #468 (comment) #501
Or is there a fix for detox 6 with Gradle 4.1 Android projects? I am facing the same issue as in #503 .

@OisinOKeeffe
Copy link

@fdnhkj I was able to get passed this by going into the build.gradle file from detox\android\detox

declare product flavors and add them to the new or old OKhttp definitions like so:
`flavorDimensions "minReactNative46"

productFlavors {
    newOkhttp {
      dimension "minReactNative46"
    }
}`

@matyj
Copy link
Author

matyj commented Jan 11, 2018

well yeah, I did that as well, but in docs you can still find info that it's supported, but you cannot install it whatsoever. I'd rather use lib according to docs instead of modifying it ^^

@rotemmiz
Copy link
Member

detox@7.0.0-alpha.0 is out. Try it, give feedback please.

@coderjonny
Copy link

coderjonny commented Jan 12, 2018

Still having some flavorDimensions gradle build issues.
I did something similar to @OisinOKeeffe but deleted anything to do with minReactNative44.
#515

@Karniej
Copy link

Karniej commented Jan 18, 2018

@rotemmiz Should the newest version of detox work with android and Genymotion ?
"react-native": "0.51.0",
"detox": "^7.0.0-alpha.0",
"babel-jest": "^22.1.0",
"jest": "^22.1.0",

I got it working for iOS, but cannot work it out with android... Recreated all the steps from the tutorial.

@stale
Copy link

stale bot commented Mar 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.
Thank you for your contributions.

@stale stale bot added the 🏚 stale label Mar 7, 2018
@stale
Copy link

stale bot commented Mar 14, 2018

The issue has been closed for inactivity.

@stale stale bot closed this as completed Mar 14, 2018
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants