Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Husky hooks bugged out when attempting a commit #606

Closed
LeoNatan opened this issue Mar 6, 2018 · 6 comments
Closed

Husky hooks bugged out when attempting a commit #606

LeoNatan opened this issue Mar 6, 2018 · 6 comments

Comments

@LeoNatan
Copy link
Contributor

LeoNatan commented Mar 6, 2018

Had to delete all hooks for the commit to succeed.
The commit in question:
6508b98

I see husky was added in Generation to run lint before committing. I am not sure whether my problem is due to husky or our own precommit hook, but either way, I am not sure this is the right place to run lint.

Regarding husky, since git hooks are considered personal and installed by developer, I do not like type of "devious" injection of code—I felt "violated" 🙂. We can run the lint on CI.

@DanielMSchmidt
Copy link
Contributor

Okay, I can remove them. I found it is a neat thing to get the info right while developing, but I can understand that this creates problems on mono repos

@LeoNatan
Copy link
Contributor Author

LeoNatan commented Mar 6, 2018

It is possible to have a script that installs some hooks that can then, by developer's choice, install these hooks. Similar to how bootstrap.sh works, maybe something for the hooks. But if the hooks can cause issues, I think they shouldn't run by default.

@LeoNatan
Copy link
Contributor Author

LeoNatan commented Mar 6, 2018

Thanks

@LeoNatan
Copy link
Contributor Author

Ping
@DanielMSchmidt What will happen if I remove it from package.json inside generation?

@DanielMSchmidt
Copy link
Contributor

You will gain the possibility to check in unformatted code I guess

@LeoNatan
Copy link
Contributor Author

OK, thanks

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants