ADB.pidof(deviceId, bundleId) does not work consistently across Android versions

[noomorph]

Description

The older API versions (e.g. Lollipop) are shipped with an older ps utility version, hence the implementation of helper method ADB.pidof() is not complete in Detox and must be extended to support a broader range of Android version.

Steps to Reproduce

Launch multiple versions (Lollipop, Marshmallow, Nougat, Oreo) in the emulator and try out running adb shell ps -AMo NAME,PID). The output is inconsistent between versions. E.g. on API 25, the output fails to be parsed correctly by the helper method ADB.pidof.

As an not totally, but stilll related illustration, see ps --version outputs on different APIs:

V5.0 -Lollipop:
USER PID PPID VSIZE RSS WCHAN PC NAME

V6.0 Marshmallow:
USER PID PPID VSIZE RSS WCHAN PC NAME

V7.0 Nougat:
bad pid '--version'

V7.1.1 Nougat:
bad pid '--version'

V8.0 Oreo:
toybox 0.7.3-05146348f7d3-android

API Level 28 :
toybox 0.7.6-android