Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of simulator name? #875

Closed
robbiemccorkell opened this issue Aug 3, 2018 · 4 comments
Closed

Allow override of simulator name? #875

robbiemccorkell opened this issue Aug 3, 2018 · 4 comments

Comments

@robbiemccorkell
Copy link
Contributor

robbiemccorkell commented Aug 3, 2018

I was wondering if you all would be open to the idea of allowing the simulator name to be parameterised in CI. We would quite like to run our tests multiple times with the same build configuration but a different simulator device.

I was thinking we could add a new CI parameter called --name or --deviceName for this that would override the one defined in the package.json config. E.g:

detox build --configuration ios.sim.release --name 'iPhone X'

I would be more than happy to submit a PR to add this if you think it's a good idea.

Thanks

@noomorph
Copy link
Collaborator

noomorph commented Aug 3, 2018

I'm not sure about @rotemmiz , but as for me - personally I like this idea about --deviceName parameter. Can be handy for quick command line runs or more sophisticated scripts...

@robbiemccorkell
Copy link
Contributor Author

Cool ok thanks. I'll add a quick PR later.

@robbiemccorkell
Copy link
Contributor Author

Also I was being dumb in my example above, obviously I meant for this to be on the test command:

detox test --configuration ios.sim.release --deviceName 'iPhone X'

But you know what I mean.

@robbiemccorkell
Copy link
Contributor Author

Submitted in #878

@noomorph noomorph closed this as completed Aug 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants