Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify setup instructions #107

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Clarify setup instructions #107

merged 1 commit into from
Apr 11, 2017

Conversation

aarongreenwald
Copy link
Contributor

After a fresh clone of the repo, lerna run build didn't work for me until I installed with lerna install. So I added it to the instructions for other clueless people :)

Also some typos/English clarification thrown in for free.

After a fresh clone of the repo, `lerna run build` didn't work for me until I installed with `lerna install`. So I added it to the instructions for other clueless people :) 

Also some typos/English clarification thrown in for free.
@aarongreenwald aarongreenwald requested a review from rotemmiz April 5, 2017 14:23
@rotemmiz
Copy link
Member

rotemmiz commented Apr 6, 2017

Thanks!!! I added a small comment re lerna install (no such command), can you please change it? we'll merge it in right after this change.

@rotemmiz rotemmiz merged commit 4eb0ebf into master Apr 11, 2017
### Installing

```sh
lerna install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be lerna bootstrap, lerna install is not a valid command

@rotemmiz rotemmiz deleted the aarongreenwald-patch-1 branch April 11, 2017 12:16
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants