Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: print simulator launch message to info #1127

Merged
merged 3 commits into from
Feb 5, 2019
Merged

code: print simulator launch message to info #1127

merged 3 commits into from
Feb 5, 2019

Conversation

noomorph
Copy link
Collaborator

@noomorph noomorph commented Jan 23, 2019 •
edited
Loading

Returns former behavior - prints where the logs are:

screenshot

Resolves #1110

TODO:

  • check CI
  • check unit tests
  • verify locally

@noomorph noomorph requested a review from rotemmiz January 23, 2019 09:36
@rotemmiz
Copy link
Member

Sorry for the mess with all those CIs, I am trying a few new ones, Bitrise seems too slow...

Anyway, looks cool

@noomorph noomorph changed the title [WIP] code: print simulator launch message to info code: print simulator launch message to info Jan 25, 2019
@noomorph
Copy link
Collaborator Author

@rotemmiz, it is ready to be merged, IMO.

@noomorph noomorph merged commit bc69538 into master Feb 5, 2019
@noomorph noomorph deleted the noomorph/print-logs-location-to-info branch February 5, 2019 12:27
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rotemmiz rotemmiz Awaiting requested review from rotemmiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noomorph @rotemmiz