export platform specific objects through proxy #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trofima
changed the title
|
Looks good! Do you have any project running with it ? Let's try running it in CI. |
…eration and related refactor.
- Updated e2e tests for demo-react-native
rotemmiz
reviewed
Dec 11, 2017
detox/src/exportWrapper.test.js
Outdated
| const exportWrapper = require('./exportWrapper'); | ||
| const platform = require('./platform'); | ||
| jest.mock('./ios/expect'); |
There was a problem hiding this comment.
make sure you reset the mocks, instead of doing it statically, require and mock everything in beforeEach inside the suite (in the describe)
detox/src/exportWrapper.test.js
Outdated
|
|
||
| it(`exports ios specific objects`, async () => { |
There was a problem hiding this comment.
These tests are not being passed locally with wallaby, I think its related to the fact that they are not being reset correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge it! It doesn't tested yet. The pull request just for starting work discussion thread for now.