Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation fix #421

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Minor documentation fix #421

merged 1 commit into from
Nov 21, 2017

Conversation

plasticine
Copy link
Contributor

What it says on the tin. 😎

@rotemmiz
Copy link
Member

The current docs are correct, we don't use callbacks to notify mocha we're done, we use async-await instead.

@rotemmiz rotemmiz closed this Nov 21, 2017
@plasticine
Copy link
Contributor Author

plasticine commented Nov 21, 2017

@rotemmiz Hey there, hrm — perhaps I should have posted a more useful PR description after all!

I’m aware of the nature of the done callback and async/await with Mocha, however the issue, if you look at the diff again, is that you’ve mixed the usage;

describe('Background push notification', () => {
  beforeEach(async () => {
    await device.relaunchApp({userNotification: userNotificationPushTrigger}, done) // <-- !?
  });
});

@rotemmiz
Copy link
Member

Ho my, I totally misread the diff. Sorry for that

@rotemmiz rotemmiz reopened this Nov 21, 2017
@rotemmiz rotemmiz merged commit 8ca372c into wix:master Nov 21, 2017
@plasticine
Copy link
Contributor Author

@rotemmiz Don’t mention it! Thanks for your work on Detox — it’s fantastic, and really exciting.

@plasticine plasticine deleted the patch-1 branch November 21, 2017 18:39
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants