Generation: Add generation for external files #465
Conversation
| module.exports = function downloadEspresso(fullyQualifiedClass) { | ||
| const tmpDir = os.tmpdir(); | ||
| const path = fullyQualifiedClass.replace(/\./g, "/"); | ||
| const fileContent = downloadFileSync( |
There was a problem hiding this comment.
I suggest you use concurrency here, this may take long time downloading files individually. I know there are a few download managers on npm that do exactly that.
There was a problem hiding this comment.
Isn't that a premature optimization? I mean this code is only executed while generating code 🤷♂️ Do you have a good opportunity at hand?
There was a problem hiding this comment.
There was a problem hiding this comment.
I gave it a try, but it made the code unnecessarily complicated to read, while I don't see this big speedup opportunities (we are talking about maybe 10 file in total, I guess). I would like to leave it this simple, but feel free to add the download package in 👍
There was a problem hiding this comment.
cool, had no idea were talking about 10 files
There was a problem hiding this comment.
recounted, it's two 😆
| @@ -18,6 +18,7 @@ | |||
| "devDependencies": { | |||
| "babel-generator": "^6.25.0", | |||
| "babel-types": "^6.25.0", | |||
| "download-file-sync": "^1.0.4", | |||
There was a problem hiding this comment.
You're not using 'download' dependency anywhere, am I missing something?
There was a problem hiding this comment.
fixed that 👍
DanielMSchmidt
force-pushed
the
add-generation-for-external-files
branch
from
30749f7 to
5906084
Compare
DanielMSchmidt
force-pushed
the
add-generation-for-external-files
branch
from
5906084 to
e518fe0
Compare
DanielMSchmidt
changed the title
DanielMSchmidt
force-pushed
the
add-generation-for-external-files
branch
from
e518fe0 to
3fb0c54
Compare
DanielMSchmidt
force-pushed
the
add-generation-for-external-files
branch
from
3fb0c54 to
5e7e76e
Compare
DanielMSchmidt
force-pushed
the
add-generation-for-external-files
branch
from
5e7e76e to
708c85a
Compare
|
@rotemmiz Tests seem green ✅ 66 passing (5m)
4 pending |
This PR allows us to get the source code of espressos APIs (which are not checked in to this project) and generate code from them. I used it for three actions, other ones will be quick wins (by adding the String type)