Add Support for ShakeDevice Action #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by sending a Darwin notification that the simulator sends when simulating shake. Native implementation needed for #551
|
@LeoNatan Can you link the earl grey PR in the comment? |
|
It's not submitted yet 😂 I will try to finish it today. Need to understand fully their code architecture before submitting. @DanielMSchmidt Would you like to add JS support? |
|
Added JS for iOS. Still need Android shake implementation. |
# Conflicts: # detox/ios/Detox.xcodeproj/project.pbxproj # detox/ios/Detox/DetoxManager.m # detox/src/client/actions/actions.js # detox/test/src/app.js
|
"Guys come on, it has been 21 days. This is very important for our customers." 😂 |
# Conflicts: # detox/test/package.json
# Conflicts: # detox/ios/Detox.xcodeproj/project.pbxproj
rotemmiz
approved these changes
Mar 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, this works by sending a Darwin notification that the simulator sends when simulating shake.
Still TODO:
Need JS support (@rotemmiz)This solves #551