Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Example .travis.yml in CI Guide #586

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Update Example .travis.yml in CI Guide #586

merged 2 commits into from
Mar 2, 2018

Conversation

mtmckenna
Copy link
Contributor

Installing applesimutils seems to be required to have builds pass in Travis.

@mtmckenna
Update Example .travis.yml in CI Guide
052b14c 
Installing applesimutils seems to be required to have builds pass in Travis.
LeoNatan
LeoNatan suggested changes Feb 28, 2018
View reviewed changes
docs/Guide.RunningOnCI.md Outdated
@@ -68,6 +68,8 @@ env:
- NODE_VERSION=stable

install:
- brew tap wix/brew
- brew install --HEAD applesimutils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do no longer use —HEAD. There are proper versions now, which should be stable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated the pull request.

@mtmckenna
Copy link
Contributor Author

Based on feedback from @LeoNatan , I removed the --HEAD argument from the brew command. I also removed --HEAD from the same command I found elsewhere in the docs.

I left the --HEAD in scripts/install.ios.sh because I didn't want this pull request to modify any code. However, perhaps it makes sense to make the change to .install.ios.sh as well in a different commit?

@mtmckenna
Copy link
Contributor Author

Hello! Anything I should do to help get this one merged in? Thank you!

@rotemmiz rotemmiz merged commit 811d763 into wix:master Mar 2, 2018
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeoNatan LeoNatan LeoNatan approved these changes

@rotemmiz rotemmiz rotemmiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtmckenna @rotemmiz @LeoNatan