CLI: add -f option to run specific test file #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Cederman had reviewed the original PR |
rotemmiz
reviewed
Mar 10, 2018
detox/local-cli/detox-test.js
Outdated
| .parse(process.argv); | ||
|
|
||
| const config = require(path.join(process.cwd(), 'package.json')).detox; | ||
|
|
||
| const testFolder = getConfigFor('specs', 'e2e'); | ||
| const testFolder = getConfigFor('file', 'specs', 'e2e'); |
There was a problem hiding this comment.
getConfigFor has two params, this puts file as key, pushing specs as default value, ignoring e2e altogether. Am I missing something ?
There was a problem hiding this comment.
I can be a good idea to extend getConfigFor to support multiple keys
and use “fallback” instead of “defaults” because it’s singular and not a keyword
jeremyeaton89
force-pushed
the
test-file-flag
branch
from
bd76fc7 to
660df9c
Compare
|
is the test failure on my end? https://travis-ci.org/wix/detox/jobs/352531838 |
rotemmiz
approved these changes
Mar 14, 2018
rotemmiz
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agnostic approach to running a specific test file.
former PR: #502