Usage with Expo instructions #630
Conversation
|
Hey, Could you add please an instruction for Android setup? I have already raised an issue #578 and my team cannot proceed with android tests. |
docs/Guide.Expo.md
Outdated
| ``` | ||
|
|
||
| - Download the Expo app from [Expo.io/tools](https://expo.io/tools). As of 03/19/18 | ||
| - [iOS IPA 2.3.0](https://dpq5q02fu5f55.cloudfront.net/Exponent-2.3.0.tar.gz) |
There was a problem hiding this comment.
Try being less specific here, we don't want to update this regularly. Just put a link to the download page (https://expo.io/tools)
docs/Guide.Expo.md
Outdated
| - [iOS IPA 2.3.0](https://dpq5q02fu5f55.cloudfront.net/Exponent-2.3.0.tar.gz) | ||
| - [Android APK 2.3.2](https://d1ahtucjixef4r.cloudfront.net/Exponent-2.3.2.apk) | ||
|
|
||
| - Unzip the iOS IPA and **rename the folder** to `Exponent.app` (it'll now be a file and not a folder) |
There was a problem hiding this comment.
It will now have a file icon (though is still a folder)
|
Thanks @rotemmiz! |
|
Hey @peterpme , Can you please relate to both platforms ? even if Android is not currently working, or you're not sure how to, just mention it in docs, se we'd take it from there. |
|
I added a TBD section for Android |
|
Please rephrase the Android part, it seems more like a personal note than documentation. 😯 |
docs/Guide.Expo.md
Outdated
| - We haven't personally tried getting this to work on Android. If you have, feel free to open up a PR! | ||
|
|
||
| ### Example App | ||
| The [example app](https://github.com/expo/with-detox-tests) is outdated but the code is exactly the same. I have a PR open that'll make it runnable again. |
There was a problem hiding this comment.
This is the line I was referring to
|
👋 @rotemmiz anything else? |
|
Hey @peterpme , looks like your PR was accepted in expo, right? |
|
@peterpme Any updates here? 😇 |
|
@DanielMSchmidt how's that? Thanks! |
| const { reloadApp } = require('detox-expo-helpers'); | ||
| // ... | ||
| beforeEach(async () => { | ||
| await reloadApp(); |
There was a problem hiding this comment.
Out of curiosity, is it possible at all to not have to reload the app in between every test? The setup/teardown process adds a fairly significant amount of time to test runs, but when I remove this beforeEach hook from my tests the tests get screwy, so I was wondering if this is just the way it is for now.
There was a problem hiding this comment.
I think this is just the way it has to be for now.
|
Hi @peterpme, thanks a lot for this from a CRNA user! |
|
Hey @CodingBauer I'm not entirely sure what your issues can be. It's been a couple months since I've opened the PR and a bunch may have changed 😅 |
|
Hey @peterpme,
I would gladly accept this docs addition, if you can please help aligning the text to these guidelines. BTW, I think it would be a good idea to actually post these, and maybe a few more, guidelines to contribution guide (we need specific guidelines for each part I guess: docs, cross platform features, sync issues, tests, etc). |
|
You got it @rotemmiz!! I'll make these adjustments over the next couple of days and we can try and get this in :) Thanks for taking the time to write that out ❤️ |
|
The changes were actually quick enough that I just took care of them. I don't know how to explain this without keeping the instructions to download the Those steps were really helpful for me when I figured them out and if I could save a developer 15-30 Either way - entirely up to you! Thanks again! |
|
Can you update this file possibly with how to use Detox using Expo on an Android device? |
No description provided.