Add no window option for running android emulator with no window #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemmiz
reviewed
Apr 26, 2018
detox/local-cli/detox-test.js
Outdated
| @@ -34,6 +34,8 @@ program | |||
| + 'e.g test with substring \':ios:\' in its name will not run when passing \'--platform android\'') | |||
| .option('-f, --file [path]', | |||
| 'Specify test file to run') | |||
| .option('-W, --nowindow', | |||
| 'Run Android without window') | |||
There was a problem hiding this comment.
1.Be as expressive as you can, this is documentation. Text suggestion: "[Android Only] Launch Emulator in headless mode. Useful when running on CI."
2. Update docs (cli section)
3. Why capital W?
4. Let's use same flag as emulator --no-window.
WDYT?
There was a problem hiding this comment.
- Ok, fixed.
- Done.
- Right, changed this to -n
- --no-window is problematic for how we are doing the flags parsing (as you said). I changed it to --noWindow
|
This is inconsistent with other methods. Look at debug-synchronization, it can still be parsed correctly to debugSynchronization |
rotemmiz
approved these changes
Apr 29, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally and passed