Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Lodash dependency to ^4.17.5 #812

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Bump Lodash dependency to ^4.17.5 #812

merged 1 commit into from
Jul 4, 2018

Conversation

noomorph
Copy link
Collaborator

@noomorph noomorph commented Jul 3, 2018

No description provided.

@noomorph noomorph requested a review from rotemmiz as a code owner July 3, 2018 18:54
@rotemmiz
Copy link
Member

rotemmiz commented Jul 4, 2018

Not that I have any objections, but semver calculation will resolve the same version for both ^4.14 and ^4.17, which is 4.x.x, so this PR doesn't really change anything in the user's bode_module dir.

@rotemmiz rotemmiz merged commit dc05229 into master Jul 4, 2018
@noomorph
Copy link
Collaborator Author

noomorph commented Jul 5, 2018

Weird... 😕
I checked https://github.com/npm/node-semver#caret-ranges-123-025-004
It says ^1.2.x := >=1.2.0 <2.0.0
So it should bump Lodash reqs at least to 4.17.x
Or am I wrong?

@noomorph noomorph deleted the noomorph/bump-versions branch July 5, 2018 04:51
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rotemmiz rotemmiz Awaiting requested review from rotemmiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noomorph @rotemmiz