Allow execution of post-install scripts on paths with space #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found that we where not able to install `detox` if the project is
installed on a path with spaces on parent directories.
For example, if we clone the project on `~/My Projects/my-project`,
running `npm install` will fail to locate the `detox/scripts/build_framework.ios.sh`.
```
/bin/sh: /Users/me/My: No such file or directory
child_process.js:615
throw err;
^
Error: Command failed: /Users/me/My Projects/my-project/node_modules/detox/scripts/build_framework.ios.sh
at checkExecSyncError (child_process.js:575:11)
```
This is related to [node's child_process](nodejs/node#6803) handling of
filepaths on `exec`.
Instead of locating the file as `~/My Projects/my-project/node_modules/detox/scripts/build_framework.ios.sh`, it passes the argument as `~/My` and fails to execute.
This commit changes the execution process to threat the first argument as a file path, instead of arguments to `exec`, which triggers the split by space to determine the arguments.
Co-Authored-By: Fellipe Chagas <fellipe.chagas@nubank.com.br>
Co-Authored-By: Rafael Correia <rafael.correia.poli@gmail.com>
|
Looks totally valid to me. @rotemmiz , what do you think? |
|
Yes, looks good. Retriggered CI. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that we where not able to install
detoxif the project isinstalled on a path with spaces on parent directories.
For example, if we clone the project on
~/My Projects/my-project,running
npm installwill fail to locate thedetox/scripts/build_framework.ios.sh.This is related to node's child_process handling of
filepaths on
exec.Instead of locating the file as
~/My Projects/my-project/node_modules/detox/scripts/build_framework.ios.sh, it passes the argument as~/Myand fails to execute.This commit changes the execution process to threat the first argument as a file path, instead of arguments to
exec, which triggers the split by space to determine the arguments.