Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine WXRNLoadIdlingResource to wait for JSDidLoad rather than ContentDidAppear #964

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Refine WXRNLoadIdlingResource to wait for JSDidLoad rather than ContentDidAppear #964

merged 4 commits into from
Oct 9, 2018

Conversation

LeoNatan
Copy link
Contributor

@LeoNatan LeoNatan commented Oct 2, 2018

Fixes #933

LeoNatan and others added 4 commits October 2, 2018 13:46
@LeoNatan
Refine WXRNLoadIdlingResource to wait for RCTJavaScriptDidLoadNotific…
0e35ed8 
…ation rather than RCTContentDidAppearNotification

Fixes #933
@LeoNatan
Test
a4f24ab 
Signed-off-by: Leo Natan <leo.natan@outlook.com>
@LeoNatan
Revert "Test"
8079383 
This reverts commit a4f24ab.

Signed-off-by: Leo Natan <leo.natan@outlook.com>
@LeoNatan
Update ReactNativeSupport.m
7098d33
@LeoNatan LeoNatan merged commit 213a204 into master Oct 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 12, 2018
@LeoNatan LeoNatan deleted the RefineWXRNLoadIdlingResource branch July 22, 2019 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status: accepted type: bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS: Hybrid app with native first screen never reports that it's ready
3 participants
@LeoNatan @rotemmiz @d4vidi