Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - non dev mode, disk space limits and file naming #18

Merged
merged 15 commits into from
Jun 12, 2024
Merged

Refactor - non dev mode, disk space limits and file naming #18

merged 15 commits into from
Jun 12, 2024

Conversation

david-i-berry
Copy link
Member

@david-i-berry
Updates to address
72adc2a 
- #15
- #14
- #13
@david-i-berry
- Refactor of app.py allow running in none dev mode.
4eded2b 
- Change to use get, post and delete to manage subscriptions
- addition of openapi doc
@david-i-berry
Addition of swagger template to render openapi doc.
0b24083 
Update of README.md
@maaikelimper
Copy link
Collaborator

maaikelimper commented Jun 10, 2024 •
edited
Loading

Please add a ERROR when WIS2DOWNLOADER_CONFIG is not set or the app crashes here:

https://github.com/wmo-im/wis2downloader/blob/minor-fixes/wis2downloader/utils/config.py#L9-L10

@maaikelimper
Copy link
Collaborator

Please document the unit for max_disk_usage and which disk it relates to

@maaikelimper
Copy link
Collaborator

I added one commit to allow testing with a non SSL secured client

maaikelimper
maaikelimper requested changes Jun 10, 2024
View reviewed changes
wis2downloader/app.py Outdated Show resolved Hide resolved
wis2downloader/utils/config.py Outdated Show resolved Hide resolved
@maaikelimper maaikelimper mentioned this pull request Jun 11, 2024
Closed
@david-i-berry
Update of readme. Update ot GET, POST and DELETE methods, e.g. POST c…
7e9ad79 
…ontent now via request body.

Improved error handling and response codes.
@david-i-berry
Copy link
Member Author

Please document the unit for max_disk_usage and which disk it relates to

Done, see also #16.

david-i-berry and others added 3 commits June 11, 2024 13:30
@maaikelimper
Copy link
Collaborator

Please add an option to disable pywis_topics-validation, I am unsure if this package is ready to be used for topic-validation at this stage.

Please ensure the text on the error-message indicates what causes the topic-validation to fail

python wis2box-ctl.py execute wis2box downloader add-subscription -t bla                                  
Subscription not added
Error: 400
<!doctype html>
<html lang=en>
<title>400 Bad Request</title>
<h1>Bad Request</h1>
<p>Invalid input (Invalid topic=bla It should not contain special characters, backslashes, or escape codes)</p>

@maaikelimper maaikelimper self-requested a review June 12, 2024 12:23
maaikelimper
maaikelimper requested changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@maaikelimper maaikelimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wmo-im/wis2downloader/blob/minor-fixes/wis2downloader/app.py#L27-L29

can you please add an option to set the loglevel so I can override default loglevel='DEBUG'

@maaikelimper maaikelimper merged commit 2dfa7cc into main Jun 12, 2024
This was referenced Jun 12, 2024
Closed
Closed
Closed
@david-i-berry david-i-berry deleted the minor-fixes branch August 15, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaikelimper maaikelimper maaikelimper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-i-berry @maaikelimper