Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging of conda env creation #371

Closed

Conversation

Tolker-KU
Copy link
Contributor

Closes #345.

@Tolker-KU Tolker-KU force-pushed the log-conda-env-creation-if-verbose branch from eb409b8 to f54a2b5 Compare December 20, 2020 09:28
@stsewd
Copy link
Collaborator

stsewd commented Dec 29, 2020

Thanks, don't think nox.options has the runtime options, that value should be passed down to the ProcessEnv class from here

https://github.com/theacodes/nox/blob/cdb391fa24a766138e596ee6b819ae49add5ec4f/nox/sessions.py#L490-L490

(there you can use sefl.global_config.verbose)

Also, maybe good to enable this for virtualenv as well https://github.com/theacodes/nox/blob/cdb391fa24a766138e596ee6b819ae49add5ec4f/nox/virtualenv.py#L404-L404

@theacodes
Copy link
Collaborator

Hi @Tolker-KU, I'd love to merge this. Do you think you can address the comments from @stsewd above? No rush, of course!

Base automatically changed from master to main February 11, 2021 23:24
@theacodes
Copy link
Collaborator

Hey folks, It looks like this PR has gone stale. If you're still interested in getting it merged, let me know and we can get this started again.

@theacodes theacodes closed this Mar 7, 2021
@Tolker-KU Tolker-KU deleted the log-conda-env-creation-if-verbose branch December 23, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Some conda commands not logged.
3 participants