Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flake8 from 3.7.8 to 3.9.2 #436

Closed
wants to merge 5 commits into from
Closed

Bump flake8 from 3.7.8 to 3.9.2 #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70bdcf3
Bump black from 19.3b0 to 21.5b2
cjolowicz Jun 3, 2021
f7d4683
Reformat with Black
cjolowicz Jun 3, 2021
95a6e53
Bump flake8 from 3.7.8 to 3.9.2
cjolowicz Jun 3, 2021
0ac6046
Fix F541 (f-string is missing placeholders)
cjolowicz Jun 3, 2021
738f932
Remove duplicate flake8 argument in lint session
cjolowicz Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nox/virtualenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ def _check_reused_environment_type(self) -> bool:
# virtualenv < 20.0 does not create pyvenv.cfg
old_env = "virtualenv"
else:
pattern = re.compile(f"virtualenv[ \t]*=")
pattern = re.compile("virtualenv[ \t]*=")
with open(path) as fp:
old_env = (
"virtualenv" if any(pattern.match(line) for line in fp) else "venv"
Expand Down
6 changes: 3 additions & 3 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@ def cover(session):
@nox.session(python="3.8")
def blacken(session):
"""Run black code formatter."""
session.install("black==19.3b0", "isort==4.3.21")
session.install("black==21.5b2", "isort==4.3.21")
files = ["nox", "tests", "noxfile.py", "setup.py"]
session.run("black", *files)
session.run("isort", "--recursive", *files)


@nox.session(python="3.8")
def lint(session):
session.install("flake8==3.7.8", "black==19.3b0", "isort==4.3.21", "mypy==0.720")
session.install("flake8==3.9.2", "black==21.5b2", "isort==4.3.21", "mypy==0.720")
session.run(
"mypy",
"--config-file=",
Expand All @@ -98,7 +98,7 @@ def lint(session):
files = ["nox", "tests", "noxfile.py", "setup.py"]
session.run("black", "--check", *files)
session.run("isort", "--check", "--recursive", *files)
session.run("flake8", "nox", *files)
session.run("flake8", *files)


@nox.session(python="3.7")
Expand Down
2 changes: 1 addition & 1 deletion tests/test_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ def test_output_decoding_utf8_only_fail(monkeypatch: pytest.MonkeyPatch) -> None


def test_output_decoding_utf8_fail_cp1252_success(
monkeypatch: pytest.MonkeyPatch
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setattr(nox.popen.locale, "getpreferredencoding", lambda: "cp1252")

Expand Down