-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GitHub Action can now be used on ubuntu-18.04 runner #606
Conversation
7551cf2
to
85aa500
Compare
16c69fb
to
0c4540d
Compare
It might be a good idea (given the number of jobs that will be run here) to put a condition in the CI workflow to only run the actions tests if Just so every PR isn't clobbered with a load of actions tests if they've not changed it Something like this: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths |
That makes sense. I'd say only run on push to I can either create a new workflow file to use built-in filtering as you mentioned or introduce a new workflow dependency https://github.com/dorny/paths-filter to keep only one workflow file. |
Yep sounds good to me! I think a separate workflow file makes the most sense to me, that way we have one for the main project and one to test the GitHub action |
0c4540d
to
78fd717
Compare
Well, GitHub doesn't allow to do an "OR filter" for push so I used |
Always install nox with python3.10 in order to allow using the action with an ubuntu-18.04 runner.
78fd717
to
d4e9436
Compare
Thanks @mayeut 🎉 |
Always install nox with python3.10 in order to allow using the action with an ubuntu-18.04 runner.