Create merchant endpoint shouldnt be called repeatedly if there is an error while creating merchants #341
Labels
type: enhancement
The issue is a request for an enhancement.
type: technical debt
This issue/PR represents/solves the technical debt of the project.
Describe the bug:
Recently on pinterest we noticed that as the error rate increased in create merchant (due to rate limiting, which was fixed by increasing the rate limit), RPS also increased. See graph below
From initial research the root cause is mostly due to healthcheck or product sync
Steps to reproduce:
Expected behavior:
When there is an error in API call, e.g in merchant creation it is better to exponentially back off rather than repeatedly try it
Actual behavior:
If there is an error in merchant creation, the create merchant is called repeatedly during health checks and product sync
Additional details:
The text was updated successfully, but these errors were encountered: