Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create merchant endpoint shouldnt be called repeatedly if there is an error while creating merchants #341

Open
adarshakb opened this issue Jan 25, 2022 · 2 comments
Labels
type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@adarshakb
Copy link

Describe the bug:

Recently on pinterest we noticed that as the error rate increased in create merchant (due to rate limiting, which was fixed by increasing the rate limit), RPS also increased. See graph below

From initial research the root cause is mostly due to healthcheck or product sync

Steps to reproduce:

  1. Create a new shop and add it to a new pinterest account
  2. Make sure merchant creation fails on pinterest side
  3. If you have multiple such failed merchant creations, then you will notice that create merchant end point will get called repeatedly

Expected behavior:

When there is an error in API call, e.g in merchant creation it is better to exponentially back off rather than repeatedly try it

Actual behavior:

If there is an error in merchant creation, the create merchant is called repeatedly during health checks and product sync

Additional details:

Screen Shot 2022-01-19 at 3 15 11 PM

@adarshakb adarshakb added the type: bug The issue is a confirmed bug. label Jan 25, 2022
@jconroy
Copy link
Member

jconroy commented Jan 26, 2022

Thanks @adarshakb 👍

@jconroy jconroy added the type: enhancement The issue is a request for an enhancement. label Jan 26, 2022
@alexiglesias31 alexiglesias31 self-assigned this Feb 3, 2022
@mikkamp mikkamp added type: technical debt This issue/PR represents/solves the technical debt of the project. and removed type: bug The issue is a confirmed bug. labels Mar 7, 2022
@jconroy
Copy link
Member

jconroy commented Jun 2, 2022

Related: #446 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Development

No branches or pull requests

4 participants