Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders list filtering (based on order status) - No UI #9

Closed
7 tasks done
astralbodies opened this issue Nov 13, 2017 · 4 comments
Closed
7 tasks done

Orders list filtering (based on order status) - No UI #9

astralbodies opened this issue Nov 13, 2017 · 4 comments
Assignees
Labels
feature: order list Related to the order list.

Comments

@astralbodies
Copy link
Contributor

astralbodies commented Nov 13, 2017

Add the ability to pass Order Status filters into the view.

  • No UI, just the capability
  • Filter based on 1 or more status items.

Based on: https://github.com/woocommerce/woocommerce-mobile/issues/89

FluxC

  • Add support for passing an order status filter to the API. Response payloads should also include the applied filter.
  • Add Instrumentation tests where necessary
  • Add some test features to the example app

UI

  • Add support for passing a filter when fetching fresh orders from the api
  • Add support for passing a filter to query the database
  • Retain applied order status filter across device configurations
  • The OrderListFragment should support setting an order status filter on creation
@AmandaRiu AmandaRiu self-assigned this Feb 8, 2018
@aforcier
Copy link
Contributor

aforcier commented Feb 9, 2018

@olaolusoga @astralbodies:

@AmandaRiu and I were discussing this item and it doesn't look like we have any design for it. Is this something we want in the MVLP?

@astralbodies
Copy link
Contributor Author

@aforcier I think the idea behind this one was the list is capable of being filtered but there isn't necessarily a UI component to it. When I tap on "orders to fulfill" from the dashboard it'll be filtered. But that does bring up a good point .... do we want the user to be able to filter/sort the list differently.

@AmandaRiu
Copy link
Contributor

@astralbodies @aforcier I'll update this ticket to reflect this is non-UI and capability only so I can move forward with it when ready. If a UI component is eventually added that can be a new ticket :)

@AmandaRiu AmandaRiu changed the title Orders list filtering (based on order status) Orders list filtering (based on order status) - No UI Feb 9, 2018
@aforcier
Copy link
Contributor

aforcier commented Feb 9, 2018

In terms of FluxC, there will be helper methods available to return all orders matching one or more statuses from the database. A more advanced addition will be to also allow fetching more orders matching some set of statuses from the server (so if you're in the "On Hold"-filtered view and swipe to the bottom, we'll fetch more "on hold" orders for you specifically).

@aforcier aforcier added this to the External closed beta group milestone Apr 26, 2018
@astralbodies astralbodies added the feature: order list Related to the order list. label May 3, 2018
@AmandaRiu AmandaRiu removed their assignment Jun 19, 2018
@AmandaRiu AmandaRiu self-assigned this Jul 23, 2018
aforcier added a commit that referenced this issue Mar 11, 2019
33d3a31 Merge pull request #10 from wordpress-mobile/merge-wpa
b3d3bc5 Update style and lint configs
752425f Update Gradle wrapper version
3bbe173 Merge commit 'e3c231d50ec6bd985404c7aec05502864b4c08d4' into subtree-updates-v3
afcb169 Merge pull request #9 from wordpress-mobile/circleci-updates
dc431ca CircleCI: Add checkstyle and assembleDebug
5ce9b47 Merge pull request #8 from wordpress-mobile/circleci
f3cad76 Removed Travis CI config
db2d8db Add CircleCI config
e81fa90 Merge pull request #9215 from wordpress-mobile/feature/update-support-lib-28
c6332e5 Move default login input row values from layout to class
2ec1551 Add icon drawable tint color assignment to login input row class
f737b09 Add icon drawable tint color to login input row attributes
8dd430c Revert update of targetSdkVersion
f50df67 Update supportLib version to 28.0.0
ac2e27a Update to Gradle 4.10.3/Android Gradle plugin 3.2.1
64e1ef8 Reorder repositories in build.gradle to fix Gradle
4896a91 Merge pull request #6 from wordpress-mobile/merge-wca
16a871b Set base button color to white
d6e2bf4 Update login library default FluxC hash
7b3ba9e Merge commit 'e500cd63388ba77e7ea13df2fbb199c64e7107c2' into feature/import-latest-login-lib
42eb5f7 Set image content description or mark it as not important for accessibility
916621c Support setting the scheme in LoginMagicLinkRequestFragment
7f9fca9 Update gradle plugin to 3.1.3
2520aa3 Update google repository config and list it first
853823c Merge pull request #217 from woocommerce/feature/113-login-notification
848294d Use more generic naming for the login notification channel id
fa437d3 Merge commit '09a0852581dd9a3a6b15109f3a8e9a80e644fbbb' into feature/update-login-library
6b07a92 Enable Google login
066bede Update gradle plugin to 3.1.2
3e1abf1 Fix FluxC build error in login library
37707a7 Merge pull request #188 from woocommerce/feature/gradle-3.1.1
1a93319 Update gradle plugin and support libraries to latest
9af7502 Update inner import checkstyle violations in login library
d07401c Update IDEA style config files
ad4fc3b Revert unintentional color change in the WordPressLoginFlow module.
c1b5671 Merge branch 'feature/order-details-screen' into feature/order-detail-views
6c93c92 Exclude utils library from FluxC imports
3727190 Merge branch 'develop' into feature/order-detail-views
eec2898 Restore login notification styling changes
103dd8f Merge commit '6bd01d64a2d01176f5b26ae36836d4f5ff0fcdc9' into feature/update-login-lib
97462cc Merge branch 'develop' into feature/order-detail-views
20e9f3b Move login icon colors to variables
b15f663 Merge branch 'develop' into feature/114-login-style-refactor
26d1088 Fix style violations in login library
17326be Order Details - Customer Info View - Action Icons and listeners, updated icon assets * Add the ability to click to dial customer phone * Add the ability to click to email customer * Add the ability to click to sms customer
ebfa842 Make login notification styling overridable
5494d0e Make login toolbar styling overridable
8cbdb5b Use overridable color names in login flow styles
e9137fe Replace WordPress buttons with LoginTheme
bf34dab Expose play-services-auth dependency from login library
1920389 Merge commit '9751124a62caad5f7c9af772f8b872b604cd02b9' into feature/gradle-3.0
f5b58af Add WPCOM_LOGIN_ONLY LoginMode, disallowing self-hosted login

git-subtree-dir: libs/login
git-subtree-split: 33d3a31
AnirudhBhat pushed a commit that referenced this issue Aug 11, 2021
CircleCI: Add checkstyle and assembleDebug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order list Related to the order list.
Projects
None yet
Development

No branches or pull requests

3 participants