Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Use Linter agent for Gradle wrapper validation #12980

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

iangmaia
Copy link
Contributor

This PR updates the pipeline config to move the Gradle Wrapper Validation from the android queue to the linter queue.

Testing

CI should be 🟢

@iangmaia iangmaia added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Nov 22, 2024
@iangmaia iangmaia self-assigned this Nov 22, 2024
@iangmaia iangmaia force-pushed the iangmaia/use-linter-for-gradle-wrapper-validation branch from 225119a to 56ada3d Compare November 22, 2024 01:02
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 22, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitb7a35f8
Direct Downloadwoocommerce-wear-prototype-build-pr12980-b7a35f8.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 22, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitb7a35f8
Direct Downloadwoocommerce-prototype-build-pr12980-b7a35f8.apk

@iangmaia iangmaia force-pushed the iangmaia/use-linter-for-gradle-wrapper-validation branch from 440c51c to 71d9e04 Compare November 22, 2024 14:09
@iangmaia
Copy link
Contributor Author

@ParaskP7 @wzieba
I've implemented the Linter command to Validate the Gradle Wrapper and this is a test PR using it. Basically the wait time for the job is very little as expected:
Screenshot 2024-11-22 at 15 11 49

What do you think, shall we experiment with it in a few projects? Do you perhaps can think of potential issues?

Copy link
Contributor

@wzieba wzieba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool @iangmaia ! Thanks for working on it. I see that on other PRs this step takes 22s-28s so it's a nice improvement. I don't see any potential issues 👍

@iangmaia iangmaia marked this pull request as ready for review November 22, 2024 15:40
@ParaskP7
Copy link
Contributor

Same to what Wojtek said @iangmaia , cool stuff and thanks for working on that! 🥇

What do you think, shall we experiment with it in a few projects?

Yes! 💯

Do you perhaps can think of potential issues?

Not off the top of my head, no. 😊

@iangmaia iangmaia added this to the 21.3 milestone Nov 22, 2024
@iangmaia iangmaia merged commit d3bda7b into trunk Nov 22, 2024
17 checks passed
@iangmaia iangmaia deleted the iangmaia/use-linter-for-gradle-wrapper-validation branch November 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants