Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks for JITM fetch failure #7656

Conversation

AnirudhBhat
Copy link
Contributor

@AnirudhBhat AnirudhBhat commented Oct 27, 2022

Closes: #7622

Description

This PR has analytics to track when the JITM API fails.

*_jitm_fetch_failure

Properties:
source : my_store
error_type
error_description

More info: pdfdoF-1zc-p2

Testing instructions

Pre-requisite

As mentioned in this post (pdfdoF-1vt-p2) make sure you have installed any one of the mentioned barcode plugin installed on your store. For example - you can install A4 Barcode Generator

Your store must be set up in the US. JITM is not supported in any other country.

  1. Turn off the internet on your mobile device
  2. Open the WooCommerce android app and you should see My Store tab by default as the first screen
  3. Check in the logs that JITM fetch failure is tracked
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…tm-fetch-failure-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
#	WooCommerce/src/test/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModelTest.kt
…tm-fetch-failure-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…tm-fetch-failure-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…ta-tapped-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…dismiss-tapped-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…itm-dismiss-success-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
#	WooCommerce/src/test/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModelTest.kt
@AnirudhBhat AnirudhBhat added feature: mobile payments Related to mobile payments / card present payments / Woo Payments. feature: analytics In-app store analytics labels Oct 27, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Oct 27, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone
Messages
📖

This PR contains changes to Tracks-related logic. Please ensure the following are completed:
PR Author

  • The PR must be assigned the Tracks label
    PR Reviewer
  • The tracks events must be validated in the Tracks system.
  • Verify the internal tracks spreadsheet has also been updated.

Generated by 🚫 dangerJS

@AnirudhBhat AnirudhBhat added this to the 11.0 milestone Oct 27, 2022
@AnirudhBhat AnirudhBhat marked this pull request as ready for review October 27, 2022 13:02
@malinajirka malinajirka self-assigned this Oct 27, 2022
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnirudhBhat !

I tested this with an Airplane mode on and the error type and description are set to "", is that expected?

…tm-fetch-failure-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…tm-displayed-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…ta-tapped-track

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
@AnirudhBhat
Copy link
Contributor Author

I tested this with an Airplane mode on and the error type and description are set to "", is that expected?

Thanks for catching this! This commit should fix this

@AnirudhBhat AnirudhBhat merged commit 2a97296 into issue/7621-jitm-fetch-success-track Oct 28, 2022
@AnirudhBhat AnirudhBhat deleted the issue/7622-jitm-fetch-failure-track branch October 28, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: analytics In-app store analytics feature: mobile payments Related to mobile payments / card present payments / Woo Payments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants