Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Buy Gift Card" button doesn't match the style of the "Add to Cart" button on the TT4. #140

Closed
iamdharmesh opened this issue May 31, 2024 · 1 comment · Fixed by #237
Assignees
Labels
needs: discussion Issue that either needs discussion or pending decision (not for support requests). priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Milestone

Comments

@iamdharmesh
Copy link
Member

Describe the bug

The "Buy Gift Card" button of the Square Gift card product doesn't match the style of the "Add to Cart" button on the TT4(Twenty Twenty-Four) Theme. It matches the style on Storefront but not match on the TT4.

To reproduce

  1. Activate TT4(Twenty Twenty-Four) Theme
  2. Create a Gift Card Product
  3. Visit the Shop page and notice that the "Buy Gift Card" button doesn't match the style of the "Add to Cart" button

Screenshots
Screenshot 2024-05-31 at 1 04 51 PM

Expected behavior

The "Buy Gift Card" button should match the style of the "Add to cart" button on the TT4(Twenty Twenty-Four) Theme.

Environment (please complete the following information):

  • WordPress Version
  • WooCommerce Version
  • WooCommerce Square Plugin Version
  • Browser [e.g. chrome, safari] and Version
  • Any other plugins installed

Additional details

System status
<!--If applicable, paste the system status here. Please ensure you redact or remove any identifying information. -->
@iamdharmesh iamdharmesh added type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: bug The issue is a confirmed bug. labels May 31, 2024
@vikrampm1 vikrampm1 added the priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. label May 31, 2024
@faisal-alvi
Copy link
Member

Hey @Sidsector9,

I noticed that the issue disappears when we stop using the woocommerce_loop_add_to_cart_link filter.

add_filter( 'woocommerce_loop_add_to_cart_link', array( $this, 'filter_shop_page_add_to_cart_button' ), 10, 3 );

It looks like this was added in https://github.com/woocommerce/woocommerce-square-private/pull/1031. I tried removing the filter, and the "Buy Gift Card" button text still shows correctly on the shop page. Is it safe to remove this filter entirely?

@faisal-alvi faisal-alvi added the needs: discussion Issue that either needs discussion or pending decision (not for support requests). label Oct 10, 2024
@MiguelAxcar MiguelAxcar self-assigned this Nov 14, 2024
@jeffpaul jeffpaul added this to the Future Release milestone Nov 25, 2024
@vikrampm1 vikrampm1 modified the milestones: Future Release, 4.8.4 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion Issue that either needs discussion or pending decision (not for support requests). priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants