Skip to content

Commit

Permalink
fix: change config.config_data column type to longblob in mysql (#2434)
Browse files Browse the repository at this point in the history
See
#2418 (comment)
for context.
  • Loading branch information
s3lph committed Sep 10, 2023
1 parent 536135b commit 0709455
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 1 deletion.
2 changes: 1 addition & 1 deletion server/model/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type Config struct {
RepoID int64 `json:"-" xorm:"UNIQUE(s) 'config_repo_id'"`
Hash string `json:"hash" xorm:"UNIQUE(s) 'config_hash'"`
Name string `json:"name" xorm:"config_name"`
Data []byte `json:"data" xorm:"config_data"`
Data []byte `json:"data" xorm:"LONGBLOB 'config_data'"`
} // @name Config

// PipelineConfig is the n:n relation between Pipeline and Config
Expand Down
37 changes: 37 additions & 0 deletions server/store/datastore/migration/024_config_data_type.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// Copyright 2023 Woodpecker Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package migration

import (
"xorm.io/xorm"
"xorm.io/xorm/schemas"
)

var alterTableConfigUpdateColumnConfigDataType = task{
name: "alter-table-config-update-type-of-config-data",
fn: func(sess *xorm.Session) (err error) {
dialect := sess.Engine().Dialect().URI().DBType

switch dialect {
case schemas.MYSQL:
_, err = sess.Exec("ALTER TABLE config MODIFY COLUMN config_data LONGBLOB")
default:
// xorm uses the same type for all blob sizes in sqlite and postgres
return nil
}

return err
},
}
1 change: 1 addition & 0 deletions server/store/datastore/migration/migration.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ var migrationTasks = []*task{
&addOrgs,
&addOrgID,
&alterTableTasksUpdateColumnTaskDataType,
&alterTableConfigUpdateColumnConfigDataType,
}

var allBeans = []interface{}{
Expand Down

0 comments on commit 0709455

Please sign in to comment.