Add support for file contents from other esbuild plugins #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcath
commented
May 10, 2021
Arcath
commented
May 10, 2021
wooorm
reviewed
May 10, 2021
|
I've updated the test. I realised I was going to have to pretty much write mdx-bundler just to run a test with |
Arcath
commented
May 10, 2021
wooorm
reviewed
May 10, 2021
wooorm
approved these changes
May 10, 2021
wooorm
changed the title
|
Released in 1.11! Thanks @Arcath! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in kentcdodds/mdx-bundler#45 this allows the esbuild plugin to accept file contents either from the disk or from
pluginData.contents. OurinMemoryplugin will use this to pass mdx content over that doesn't exist on the disk.