From 34a73501d8c8288a0fb9bc23c831c572ed706079 Mon Sep 17 00:00:00 2001 From: JunH Date: Tue, 17 Oct 2023 16:04:36 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20(#746)=20repository=20=EB=A9=94?= =?UTF-8?q?=EC=84=9C=EB=93=9C=EB=AA=85=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../domain/report/repository/ReportCustomRepository.java | 2 +- .../domain/report/repository/ReportCustomRepositoryImpl.java | 2 +- .../votogether/domain/report/service/ReportQueryService.java | 2 +- .../report/repository/ReportCustomRepositoryImplTest.java | 3 +-- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/backend/src/main/java/com/votogether/domain/report/repository/ReportCustomRepository.java b/backend/src/main/java/com/votogether/domain/report/repository/ReportCustomRepository.java index 55fd4c35d..1c9616ca6 100644 --- a/backend/src/main/java/com/votogether/domain/report/repository/ReportCustomRepository.java +++ b/backend/src/main/java/com/votogether/domain/report/repository/ReportCustomRepository.java @@ -6,6 +6,6 @@ public interface ReportCustomRepository { - List findReportsGroupedByMemberAndReportTypeAndTargetId(final Pageable pageable); + List findReportsGroupedByReportTypeAndTargetId(final Pageable pageable); } diff --git a/backend/src/main/java/com/votogether/domain/report/repository/ReportCustomRepositoryImpl.java b/backend/src/main/java/com/votogether/domain/report/repository/ReportCustomRepositoryImpl.java index 4e57f4b5c..55c7f2ed4 100644 --- a/backend/src/main/java/com/votogether/domain/report/repository/ReportCustomRepositoryImpl.java +++ b/backend/src/main/java/com/votogether/domain/report/repository/ReportCustomRepositoryImpl.java @@ -18,7 +18,7 @@ public class ReportCustomRepositoryImpl implements ReportCustomRepository { private final JPAQueryFactory jpaQueryFactory; @Override - public List findReportsGroupedByMemberAndReportTypeAndTargetId(final Pageable pageable) { + public List findReportsGroupedByReportTypeAndTargetId(final Pageable pageable) { return jpaQueryFactory.select( Projections.constructor( ReportAggregateDto.class, diff --git a/backend/src/main/java/com/votogether/domain/report/service/ReportQueryService.java b/backend/src/main/java/com/votogether/domain/report/service/ReportQueryService.java index 35cecb824..8bee3e6bd 100644 --- a/backend/src/main/java/com/votogether/domain/report/service/ReportQueryService.java +++ b/backend/src/main/java/com/votogether/domain/report/service/ReportQueryService.java @@ -29,7 +29,7 @@ public ReportPageResponse getReports(final int page) { final Pageable pageable = PageRequest.of(page, BASIC_PAGE_SIZE); final List reportAggregateDtos = reportRepository - .findReportsGroupedByMemberAndReportTypeAndTargetId(pageable); + .findReportsGroupedByReportTypeAndTargetId(pageable); final List reportResponses = parseReportResponses(reportAggregateDtos); return ReportPageResponse.of(totalPageNumber, page, reportResponses); diff --git a/backend/src/test/java/com/votogether/domain/report/repository/ReportCustomRepositoryImplTest.java b/backend/src/test/java/com/votogether/domain/report/repository/ReportCustomRepositoryImplTest.java index c236cb5b4..28076e3f5 100644 --- a/backend/src/test/java/com/votogether/domain/report/repository/ReportCustomRepositoryImplTest.java +++ b/backend/src/test/java/com/votogether/domain/report/repository/ReportCustomRepositoryImplTest.java @@ -12,7 +12,6 @@ import java.time.LocalDateTime; import java.time.temporal.ChronoUnit; import java.util.List; -import org.assertj.core.api.RecursiveComparisonAssert; import org.assertj.core.api.SoftAssertions; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; @@ -67,7 +66,7 @@ void getReports() { // when final List reports = reportCustomRepository - .findReportsGroupedByMemberAndReportTypeAndTargetId(pageRequest); + .findReportsGroupedByReportTypeAndTargetId(pageRequest); // then assertSoftly(softly -> {