diff --git a/backend/src/docs/asciidoc/review-list.adoc b/backend/src/docs/asciidoc/review-list.adoc index 229c3d34d..d0cf479ba 100644 --- a/backend/src/docs/asciidoc/review-list.adoc +++ b/backend/src/docs/asciidoc/review-list.adoc @@ -4,4 +4,4 @@ operation::received-review-list-with-pagination[snippets="curl-request,request-c ==== 자신이 작성한 리뷰 목록 조회 -operation::written-review-list-with-pagination[snippets="curl-request,query-parameters,http-response,response-fields"] +operation::authored-review-list-with-pagination[snippets="curl-request,query-parameters,http-response,response-fields"] diff --git a/backend/src/main/java/reviewme/review/controller/ReviewController.java b/backend/src/main/java/reviewme/review/controller/ReviewController.java index c06383254..aadd5641b 100644 --- a/backend/src/main/java/reviewme/review/controller/ReviewController.java +++ b/backend/src/main/java/reviewme/review/controller/ReviewController.java @@ -20,7 +20,7 @@ import reviewme.review.service.dto.response.gathered.ReviewsGatheredBySectionResponse; import reviewme.review.service.dto.response.list.ReceivedReviewsResponse; import reviewme.review.service.dto.response.list.ReceivedReviewsSummaryResponse; -import reviewme.review.service.dto.response.list.WrittenReviewsResponse; +import reviewme.review.service.dto.response.list.AuthoredReviewsResponse; import reviewme.reviewgroup.controller.ReviewGroupSession; import reviewme.reviewgroup.domain.ReviewGroup; @@ -79,13 +79,13 @@ public ResponseEntity getReceivedReviewsBySect } @GetMapping("/v2/reviews/authored") - public ResponseEntity findWrittenReviews( + public ResponseEntity findAuthoredReviews( @RequestParam(required = false) Long lastReviewId, @RequestParam(required = false) Integer size // @MemberSession Member member // TODO: 세션을 활용한 권한 체계에 따른 추가 조치 필요 ) { - WrittenReviewsResponse response = reviewListLookupService.getWrittenReviews(lastReviewId, size); + AuthoredReviewsResponse response = reviewListLookupService.getAuthoredReviews(lastReviewId, size); return ResponseEntity.ok(response); } } diff --git a/backend/src/main/java/reviewme/review/service/ReviewListLookupService.java b/backend/src/main/java/reviewme/review/service/ReviewListLookupService.java index 4cf5de77e..7eee3ee03 100644 --- a/backend/src/main/java/reviewme/review/service/ReviewListLookupService.java +++ b/backend/src/main/java/reviewme/review/service/ReviewListLookupService.java @@ -7,7 +7,7 @@ import reviewme.review.repository.ReviewRepository; import reviewme.review.service.dto.response.list.ReceivedReviewsResponse; import reviewme.review.service.dto.response.list.ReviewListElementResponse; -import reviewme.review.service.dto.response.list.WrittenReviewsResponse; +import reviewme.review.service.dto.response.list.AuthoredReviewsResponse; import reviewme.review.service.mapper.ReviewListMapper; import reviewme.reviewgroup.domain.ReviewGroup; @@ -30,7 +30,7 @@ public ReceivedReviewsResponse getReceivedReviews(Long lastReviewId, Integer siz ); } - public WrittenReviewsResponse getWrittenReviews(Long lastReviewId, Integer size) { + public AuthoredReviewsResponse getAuthoredReviews(Long lastReviewId, Integer size) { // TODO: 생성일자 최신순 정렬 return null; } diff --git a/backend/src/main/java/reviewme/review/service/dto/response/list/WrittenReviewElementResponse.java b/backend/src/main/java/reviewme/review/service/dto/response/list/AuthoredReviewElementResponse.java similarity index 86% rename from backend/src/main/java/reviewme/review/service/dto/response/list/WrittenReviewElementResponse.java rename to backend/src/main/java/reviewme/review/service/dto/response/list/AuthoredReviewElementResponse.java index 8f9f59757..282f6dbd3 100644 --- a/backend/src/main/java/reviewme/review/service/dto/response/list/WrittenReviewElementResponse.java +++ b/backend/src/main/java/reviewme/review/service/dto/response/list/AuthoredReviewElementResponse.java @@ -3,7 +3,7 @@ import java.time.LocalDate; import java.util.List; -public record WrittenReviewElementResponse( +public record AuthoredReviewElementResponse( long reviewId, String revieweeName, String projectName, diff --git a/backend/src/main/java/reviewme/review/service/dto/response/list/WrittenReviewsResponse.java b/backend/src/main/java/reviewme/review/service/dto/response/list/AuthoredReviewsResponse.java similarity index 59% rename from backend/src/main/java/reviewme/review/service/dto/response/list/WrittenReviewsResponse.java rename to backend/src/main/java/reviewme/review/service/dto/response/list/AuthoredReviewsResponse.java index e0cd392ed..7d712a31c 100644 --- a/backend/src/main/java/reviewme/review/service/dto/response/list/WrittenReviewsResponse.java +++ b/backend/src/main/java/reviewme/review/service/dto/response/list/AuthoredReviewsResponse.java @@ -2,8 +2,8 @@ import java.util.List; -public record WrittenReviewsResponse( - List reviews, +public record AuthoredReviewsResponse( + List reviews, long lastReviewId, boolean isLastPage ) { diff --git a/backend/src/test/java/reviewme/api/ReviewApiTest.java b/backend/src/test/java/reviewme/api/ReviewApiTest.java index 1a1e8d757..8df705eff 100644 --- a/backend/src/test/java/reviewme/api/ReviewApiTest.java +++ b/backend/src/test/java/reviewme/api/ReviewApiTest.java @@ -33,8 +33,8 @@ import reviewme.review.service.dto.response.list.ReceivedReviewsSummaryResponse; import reviewme.review.service.dto.response.list.ReviewCategoryResponse; import reviewme.review.service.dto.response.list.ReviewListElementResponse; -import reviewme.review.service.dto.response.list.WrittenReviewElementResponse; -import reviewme.review.service.dto.response.list.WrittenReviewsResponse; +import reviewme.review.service.dto.response.list.AuthoredReviewElementResponse; +import reviewme.review.service.dto.response.list.AuthoredReviewsResponse; import reviewme.reviewgroup.service.exception.ReviewGroupNotFoundByReviewRequestCodeException; import reviewme.template.domain.QuestionType; @@ -352,14 +352,14 @@ class ReviewApiTest extends ApiTest { @Test void 자신이_작성한_리뷰_목록을_조회한다() { - List writtenReviews = List.of( - new WrittenReviewElementResponse(1L, "테드1", "리뷰미", LocalDate.of(2024, 8, 2), "(리뷰 미리보기 1)", + List authoredReviews = List.of( + new AuthoredReviewElementResponse(1L, "테드1", "리뷰미", LocalDate.of(2024, 8, 2), "(리뷰 미리보기 1)", List.of(new ReviewCategoryResponse(1L, "카테고리 1"))), - new WrittenReviewElementResponse(2L, "테드2", "리뷰미", LocalDate.of(2024, 8, 1), "(리뷰 미리보기 2)", + new AuthoredReviewElementResponse(2L, "테드2", "리뷰미", LocalDate.of(2024, 8, 1), "(리뷰 미리보기 2)", List.of(new ReviewCategoryResponse(2L, "카테고리 2"))) ); - WrittenReviewsResponse response = new WrittenReviewsResponse(writtenReviews, 1L, true); - BDDMockito.given(reviewListLookupService.getWrittenReviews(anyLong(), anyInt())) + AuthoredReviewsResponse response = new AuthoredReviewsResponse(authoredReviews, 1L, true); + BDDMockito.given(reviewListLookupService.getAuthoredReviews(anyLong(), anyInt())) .willReturn(response); CookieDescriptor[] cookieDescriptors = { @@ -388,7 +388,7 @@ class ReviewApiTest extends ApiTest { }; RestDocumentationResultHandler handler = document( - "written-review-list-with-pagination", + "authored-review-list-with-pagination", requestCookies(cookieDescriptors), queryParameters(queryParameter), responseFields(responseFieldDescriptors)