[Gutenberg] Gallery refactor as nested image blocks #14769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This detects the new format via the presence of the `imageCount` property in the block's json and defers processing to the image block processor (recursively through the `processContent` method).
…rnmobile/refactor/gallery-as-nested-image-blocks-update-processor
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
2 tasks
|
You can test the changes on this Pull Request by downloading the APKs: |
…rnmobile/refactor/gallery-as-nested-image-blocks-update-processor
…rnmobile/refactor/gallery-as-nested-image-blocks-update-processor
…lery-as-nested-image-blocks-update-processor [Gutenberg] Gallery refactor - Update upload completion processor
4 tasks
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
gutenberg: WordPress/gutenberg#32382gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3579WordPress-iOS: wordpress-mobile/WordPress-iOS#16699Description
This PR brings in the refactored Gallery block with inner image blocks.
To test:
This has already been tested via the only "sub PR". Originally, this PR was going to include other changes to bring in the flag from editor settings as well, but that can be handled independently in a subsequent PR.
PR submission checklist:
RELEASE-NOTES.txtif necessary.