Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry picks null check commit #9500

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Cherry picks null check commit #9500

merged 1 commit into from
Apr 1, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Apr 1, 2019

Applies #9497 (already approved) to release/12.1

Check #9497 (comment) for more info

cc @jtreanor

@mzorz
added null check as tracker may not have been initialized if site or …
d10e6b5 
…Post were null in the first place and Editor was exited preemptively
@mzorz mzorz requested a review from jtreanor April 1, 2019 11:30
@jtreanor jtreanor added this to the 12.1 ❄️ milestone Apr 1, 2019
jtreanor
jtreanor approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@jtreanor jtreanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @mzorz!

@jtreanor jtreanor merged commit edcb61c into release/12.1 Apr 1, 2019
@jtreanor jtreanor deleted the fix/npe-editor-session-tracker-cherry-pick branch April 1, 2019 11:39
@jtreanor jtreanor mentioned this pull request Apr 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtreanor jtreanor jtreanor approved these changes

Assignees
No one assigned
Labels
[Type] Crash
Projects
None yet
Milestone
12.1 ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@mzorz @jtreanor