Merge release/26.4 into trunk (#24933)

* Enable New Stats for fresh install (#24921)

* Fix Reader insets on ipad (#24922)

* Enable Intelligence FF for Jetpack (#24923)

* feat: Disable header navigation when GutenbergKit opens dialogs (#24917)

* feat: Disable header navigation when GutenbergKit opens dialogs

Disabling the native header navigation respects GutenbergKit's web-based
modal dialogs, where focus should remain on the dialog to mitigate
confusion from surrounding UI elements.

* build: Update GutenbergKit version

* Revert "build: Update GutenbergKit version"

This reverts commit 3f758ad.

* build: Update GutenbergKit version

* fix: GutenbergKit allows empty editor settings (#24924)

Sites without GutenbergKit plugin do not have the editor settings REST
API endpoint. For these sites or missing settings due to other reasons,
we should allow the editor to open with empty editor settings.

This approach aligns with the original implementation:

ac3ad4c#diff-985e4813fea24c7bfb37425f15af08cda2f4ace0da805b3eecc249862fdca2d5L362-L367

* Revert "Remove a few applicationIconBadgeNumber API calls" (#24928)

This reverts commit 25c1ed7.

* Fully release WP.com web based login

* Update app translations – `Localizable.strings`

* Update WordPress metadata translations

* Update Jetpack metadata translations

* Bump version number

* Fix Xcode warning (#24926)

* Fix robocop warning

```
fastlane/lanes/screenshots.rb#L14: Layout/TrailingWhitespace: Trailing whitespace detected.
```

---------

Co-authored-by: Alex Grebenyuk <alex.grebenyuk@automattic.com>
Co-authored-by: David Calhoun <github@davidcalhoun.me>
Co-authored-by: Tony Li <tony.li@automattic.com>

Author: 4 people

Modules/Package.resolved

@@ -53,7 +53,7 @@ let package = Package(
         .package(url: "https://github.com/zendesk/support_sdk_ios", from: "8.0.3"),
         // We can't use wordpress-rs branches nor commits here. Only tags work.
         .package(url: "https://github.com/Automattic/wordpress-rs", revision: "alpha-20250926"),
-        .package(url: "https://github.com/wordpress-mobile/GutenbergKit", from: "0.8.1-alpha.2"),
+        .package(url: "https://github.com/wordpress-mobile/GutenbergKit", from: "0.9.0"),
         .package(
             url: "https://github.com/Automattic/color-studio",
             revision: "bf141adc75e2769eb469a3e095bdc93dc30be8de"

Modules/Package.swift

@@ -1,6 +1,5 @@
 import XCTest
 import WordPressData
-import UserNotifications
 @testable import WordPress
 
 final class NotificationsViewControllerTests: XCTestCase {
@@ -47,7 +46,7 @@ final class NotificationsViewControllerTests: XCTestCase {
     func testResetApplicationBadgeWhenAccountChange() throws {
         // Give
         let newUnreadCount = 1
-        UNUserNotificationCenter.current().setBadgeCount(0)
+        UIApplication.shared.applicationIconBadgeNumber = 0
         ZendeskUtils.unreadNotificationsCount = newUnreadCount
 
         // When

Tests/KeystoneTests/Tests/Features/Notifications/NotificationsViewControllerTests.swift

@@ -27,6 +27,12 @@ class RemoteFeatureFlagStore {
         return deviceID
     }
 
+    /// Returns `true` if the store hasn't been updated yet. It uses the
+    /// presence of `deviceID` as an indicator of the previous install.
+    public var isFreshInstall: Bool {
+        persistenceStore.string(forKey: Constants.DeviceIdKey) == nil
+    }
+
     init(persistenceStore: UserPersistentRepository = UserDefaults.standard) {
         self.persistenceStore = persistenceStore
     }

WordPress/Classes/Stores/RemoteFeatureFlagStore.swift

@@ -28,7 +28,7 @@ extension WordPressAuthenticator: WordPressAuthenticatorProtocol {
             return false
         }
 
-        return RemoteFeatureFlag.dotComWebLogin.enabled()
+        return true
     }
 
     private static func continueWithDotCom(_ viewController: UIViewController) -> Bool {

WordPress/Classes/System/Root View/WordPressAuthenticatorProtocol.swift

@@ -533,6 +533,11 @@ extension WordPressAppDelegate {
             FeatureFlagOverrideStore().override(RemoteFeatureFlag.dotComWebLogin, withValue: true)
         }
 
+        /// - warning: must be called before the `update(using:then:)`.
+        if remoteFeatureFlagStore.isFreshInstall {
+            FeatureFlagOverrideStore().override(FeatureFlag.newStats, withValue: true)
+        }
+
         var api: WordPressComRestApi
         if let authToken {
             api = WordPressComRestApi.defaultV2Api(authToken: authToken)

WordPress/Classes/System/WordPressAppDelegate.swift

@@ -75,7 +75,7 @@ public final class PushNotificationsManager: NSObject {
             sharedApplication.registerForRemoteNotifications()
         }
         sharedApplication.unregisterForRemoteNotifications()
-        UNUserNotificationCenter.current().setBadgeCount(0)
+        sharedApplication.applicationIconBadgeNumber = 0
         didRegisterForRemoteNotifications = false
     }
 
@@ -187,7 +187,7 @@ public final class PushNotificationsManager: NSObject {
 
         // Badge: Update
         if let badgeCountNumber = userInfo.number(forKeyPath: Notification.badgePath)?.intValue {
-            UNUserNotificationCenter.current().setBadgeCount(badgeCountNumber)
+            sharedApplication.applicationIconBadgeNumber = badgeCountNumber
         }
 
         // Badge: Reset

WordPress/Classes/Utility/Notifications/PushNotificationsManager.swift

@@ -307,7 +307,7 @@ class ZendeskUtils: NSObject, ZendeskUtilsProtocol {
     /// - post an NSNotification so the various indicators can be cleared.
     ///
     static func pushNotificationRead() {
-        UNUserNotificationCenter.current().setBadgeCount(UIApplication.shared.applicationIconBadgeNumber - unreadNotificationsCount)
+        UIApplication.shared.applicationIconBadgeNumber -= unreadNotificationsCount
         unreadNotificationsCount = 0
         saveUnreadCount()
         postNotificationRead()

WordPress/Classes/Utility/ZendeskUtils.swift

@@ -96,4 +96,12 @@ extension CommentGutenbergEditorViewController: GutenbergKit.EditorViewControlle
     func editor(_ viewController: GutenbergKit.EditorViewController, didTriggerAutocompleter type: String) {
         // Do nothing
     }
+
+    func editor(_ viewController: GutenbergKit.EditorViewController, didOpenModalDialog dialogType: String) {
+        // Do nothing
+    }
+
+    func editor(_ viewController: GutenbergKit.EditorViewController, didCloseModalDialog dialogType: String) {
+        // Do nothing
+    }
 }

WordPress/Classes/ViewRelated/Comments/Controllers/Editor/CommentGutenbergEditorViewController.swift

@@ -51,7 +51,7 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
     }
 
     struct EditorDependencies {
-        let settings: String
+        let settings: String?
         let didLoadCookies: Bool
     }
 
@@ -111,6 +111,7 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
     private var editorViewController: GutenbergKit.EditorViewController
     private var activityIndicator: UIActivityIndicatorView?
     private var hasEditorStarted = false
+    private var isModalDialogOpen = false
 
     lazy var autosaver = Autosaver() {
         self.performAutoSave()
@@ -383,13 +384,13 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
     }
 
     @MainActor
-    func startEditor(settings: String) async throws {
+    func startEditor(settings: String?) async throws {
         guard case .dependenciesReady = self.editorState else {
             preconditionFailure("`startEditor` should only be called when the editor is in the `.dependenciesReady` state.")
         }
 
         let updatedConfiguration = self.editorViewController.configuration.toBuilder()
-            .setEditorSettings(settings)
+            .apply(settings) { $0.setEditorSettings($1) }
             .setTitle(post.postTitle ?? "")
             .setContent(post.content ?? "")
             .build()
@@ -469,7 +470,14 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
 
     // MARK: - Editor Setup
     private func fetchEditorDependencies() async throws -> EditorDependencies {
-        let settings = try await blockEditorSettingsService.getSettingsString(allowingCachedResponse: true)
+        let settings: String?
+        do {
+            settings = try await blockEditorSettingsService.getSettingsString(allowingCachedResponse: true)
+        } catch {
+            DDLogError("Failed to fetch editor settings: \(error)")
+            settings = nil
+        }
+
         let loaded = await loadAuthenticationCookiesAsync()
 
         return EditorDependencies(settings: settings, didLoadCookies: loaded)
@@ -496,6 +504,14 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
             }
         }
     }
+
+    private func setNavigationItemsEnabled(_ enabled: Bool) {
+        navigationBarManager.closeButton.isEnabled = enabled
+        navigationBarManager.moreButton.isEnabled = enabled
+        navigationBarManager.publishButton.isEnabled = enabled
+        navigationBarManager.undoButton.isEnabled = enabled
+        navigationBarManager.redoButton.isEnabled = enabled
+    }
 }
 
 extension NewGutenbergViewController: GutenbergKit.EditorViewControllerDelegate {
@@ -608,6 +624,16 @@ extension NewGutenbergViewController: GutenbergKit.EditorViewControllerDelegate
         }
     }
 
+    func editor(_ viewController: GutenbergKit.EditorViewController, didOpenModalDialog dialogType: String) {
+        isModalDialogOpen = true
+        setNavigationItemsEnabled(false)
+    }
+
+    func editor(_ viewController: GutenbergKit.EditorViewController, didCloseModalDialog dialogType: String) {
+        isModalDialogOpen = false
+        setNavigationItemsEnabled(true)
+    }
+
     private func convertMediaInfoArrayToJSONString(_ mediaInfoArray: [MediaInfo]) -> String? {
         do {
             let jsonData = try JSONEncoder().encode(mediaInfoArray)