-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Gallery as nested image blocks #16699
Merged
antonis
merged 5 commits into
develop
from
gutenberg/refactor/gallery-as-nested-image-blocks
Jul 7, 2021
Merged
Refactor Gallery as nested image blocks #16699
antonis
merged 5 commits into
develop
from
gutenberg/refactor/gallery-as-nested-image-blocks
Jul 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Jun 17, 2021
…ctored gallery block
…llery-refactor-tests [Gutenberg] Gallery refactor - Test upload completion processor
This reverts commit d3b6e7c.
Generated by 🚫 dangerJS |
mkevins
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as already reviewed and tested via the only "sub PR". Thanks Antonis!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg
: WordPress/gutenberg#32382gutenberg-mobile
: wordpress-mobile/gutenberg-mobile#3579WordPress-Android
: wordpress-mobile/WordPress-Android#14769Sub PRs:
Description
This PR brings in the refactored Gallery block with inner image blocks. No actual functional code was needed for this. Only tests were added to validate that the current upload completion processor can handle the new refactored gallery.
To test:
Check #16721
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
Check [Gutenberg] Gallery refactor - Test upload completion processor #16721
PR submission checklist:
RELEASE-NOTES.txt
if necessary.