Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Gallery as nested image blocks #16699

Merged
merged 5 commits into from
Jul 7, 2021

Conversation

antonis
Copy link

@antonis antonis commented Jun 17, 2021

gutenberg: WordPress/gutenberg#32382
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3579
WordPress-Android: wordpress-mobile/WordPress-Android#14769

Sub PRs:

Description

This PR brings in the refactored Gallery block with inner image blocks. No actual functional code was needed for this. Only tests were added to validate that the current upload completion processor can handle the new refactored gallery.

To test:
Check #16721

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    Check [Gutenberg] Gallery refactor - Test upload completion processor #16721

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 17, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 17, 2021

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 52368. IPA is available here. If you need access to this, you can ask a maintainer to add you.

Antonis Lilis added 2 commits June 22, 2021 14:25
…llery-refactor-tests

[Gutenberg] Gallery refactor - Test upload completion processor
@antonis antonis marked this pull request as ready for review July 7, 2021 05:34
@antonis antonis requested a review from mkevins July 7, 2021 05:35
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as already reviewed and tested via the only "sub PR". Thanks Antonis!

@antonis antonis merged commit f604816 into develop Jul 7, 2021
@antonis antonis deleted the gutenberg/refactor/gallery-as-nested-image-blocks branch July 7, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants