[Gutenberg] Gallery refactor - Test upload completion processor #16721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctored gallery block
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
4 tasks
mkevins
reviewed
Jun 28, 2021
Comment on lines
+107
to
+109
| var resultContent = galleryBlockContent | ||
|
|
||
| resultContent = mediaJobs.reduce(into: resultContent) { (content, mediaJob) in |
There was a problem hiding this comment.
Maybe this was an error in extracting, we overwrite this immediately afterwards
There was a problem hiding this comment.
Nvm I see we use it on the RHS in the reducer
mkevins
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR only adds tests to verify that the existing Gallery block upload completion processor can handle the refactored format. This adds to the existing tests for the Image and Gallery processors.
To test:
Run the upload completion processor unit tests.
Manual testing the existing Gallery block upload completion processor:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
Added tests under
GutenbergRefactoredGalleryUploadProcessorTestsPR submission checklist:
RELEASE-NOTES.txtif necessary.