Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TipKit FF #23661

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Enable TipKit FF #23661

merged 1 commit into from
Oct 7, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 7, 2024

Fixes #

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Oct 7, 2024
@kean kean added this to the 25.4 ❄️ milestone Oct 7, 2024
@kean kean requested a review from crazytonyli October 7, 2024 14:05
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.4 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23661-7d61b7a
Version25.4
Bundle IDorg.wordpress.alpha
Commit7d61b7a
App Center BuildWPiOS - One-Offs #10792
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23661-7d61b7a
Version25.4
Bundle IDcom.jetpack.alpha
Commit7d61b7a
App Center Buildjetpack-installable-builds #9834
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit 945c911 into release/25.4 Oct 7, 2024
26 checks passed
@kean kean deleted the task/enable-tipkit-ff branch October 7, 2024 16:51
github-merge-queue bot pushed a commit that referenced this pull request Oct 7, 2024
@wpmobilebot @jkmassel
@iangmaia @mokagio @crazytonyli @dcalhoun @kean @oguzkocer
Merge release/25.4 into trunk (#23665)
cfde199 
* Bump version number

* Update draft release notes for 25.4.

* Update draft release notes for 25.4.

* Release Notes: add new section for next version (25.5)

* Update strings for localization

* Shave a few bytes off all our icons

* Update app translations – `Localizable.strings`

* Update WordPress metadata translations

* Update Jetpack metadata translations

* Bump version number

* Remove alpha channel from WordPress light icon (Any Appearance)

This was done to address an iTMS rejection:

  Asset validation failed (90717) Invalid large app icon.
  The large app icon in the asset catalog in “WordPress.app” can’t be transparent or contain an alpha channel.
  For details, visit: https://developer.apple.com/design/human-interface-guidelines/app-icons.

See https://buildkite.com/automattic/wordpress-ios/builds/24053#019234f2-8086-4160-904a-328283175b3b

This was done via Preview.app: Export... > PNG unticking the "Alpha"
channel.

* Upload Fastlane to handle occasional ASC upload issue

* Update app translations – `Localizable.strings`

* Bump version number

* Bump version number

* Stop handling WordPress.com links in the WordPress app (#23653)

* Stop handling WordPress.com links in the WordPress app

* Address a build failure in the tests because of unhandled `XCTSkip`

---------

Co-authored-by: Gio Lodi <gio@mokacoding.com>

* feat: Synchronize content with GutenbergKit (#23631)

* Merge release/25.4 into trunk (#23628)

* Bump version number

* Update draft release notes for 25.4.

* Update draft release notes for 25.4.

* Release Notes: add new section for next version (25.5)

* Update strings for localization

* feat: Persist GutenbergKit changes

Ensure post changes are not lost.

* fix: Persist changes if either post title or content changes

The previous conditional erroneously ignored changes unless both values
changed.

* build: Update GutenbergKit ref

* fix: Improve empty editor content check

As noted in the code comment, this value lags behind reality. A race
condition existed in production builds cause inaccurate values. This was
removed to instead rely upon the existing `editorHasContent`
implementation found in the `PostEditor` class.

* build: Update GutenbergKit ref

* build: Update GutenbergKit ref

* build: Update GutenbergKit ref

* Update GutenbergKit ref

* Update GutenbergKit ref

---------

Co-authored-by: WordPress Mobile Bot Account <mobile+wpmobilebot@automattic.com>
Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
Co-authored-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>

* Fix an issue with comment selection state disappearing (#23658)

* Disable Reader anouncemnets (#23655)

* Fix an issue with Me header view alignment (#23647)

* Add Gutenberg Experimental Editor Switch (#23660)

* Add TipKit for Sidebar (#23648)

* Enable TipKit FF (#23661)

* Fix crash in TipKit (#23664)

* Update strings for localization

* Update app translations – `Localizable.strings`

* Bump version number

---------

Co-authored-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Co-authored-by: Ian Maia <ian.maia@automattic.com>
Co-authored-by: Gio Lodi <gio@mokacoding.com>
Co-authored-by: Tony Li <tony.li@automattic.com>
Co-authored-by: David Calhoun <github@davidcalhoun.me>
Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
Co-authored-by: Alex Grebenyuk <alex.grebenyuk@automattic.com>
Co-authored-by: Oguz Kocer <oguz.kocer@automattic.com>
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2024
@wpmobilebot @jkmassel
@iangmaia @mokagio @crazytonyli @dcalhoun @kean @oguzkocer
Merge release/25.4 into trunk (#23673)
ebfd142 
* Bump version number

* Update draft release notes for 25.4.

* Update draft release notes for 25.4.

* Release Notes: add new section for next version (25.5)

* Update strings for localization

* Shave a few bytes off all our icons

* Update app translations – `Localizable.strings`

* Update WordPress metadata translations

* Update Jetpack metadata translations

* Bump version number

* Remove alpha channel from WordPress light icon (Any Appearance)

This was done to address an iTMS rejection:

  Asset validation failed (90717) Invalid large app icon.
  The large app icon in the asset catalog in “WordPress.app” can’t be transparent or contain an alpha channel.
  For details, visit: https://developer.apple.com/design/human-interface-guidelines/app-icons.

See https://buildkite.com/automattic/wordpress-ios/builds/24053#019234f2-8086-4160-904a-328283175b3b

This was done via Preview.app: Export... > PNG unticking the "Alpha"
channel.

* Upload Fastlane to handle occasional ASC upload issue

* Update app translations – `Localizable.strings`

* Bump version number

* Bump version number

* Stop handling WordPress.com links in the WordPress app (#23653)

* Stop handling WordPress.com links in the WordPress app

* Address a build failure in the tests because of unhandled `XCTSkip`

---------

Co-authored-by: Gio Lodi <gio@mokacoding.com>

* feat: Synchronize content with GutenbergKit (#23631)

* Merge release/25.4 into trunk (#23628)

* Bump version number

* Update draft release notes for 25.4.

* Update draft release notes for 25.4.

* Release Notes: add new section for next version (25.5)

* Update strings for localization

* feat: Persist GutenbergKit changes

Ensure post changes are not lost.

* fix: Persist changes if either post title or content changes

The previous conditional erroneously ignored changes unless both values
changed.

* build: Update GutenbergKit ref

* fix: Improve empty editor content check

As noted in the code comment, this value lags behind reality. A race
condition existed in production builds cause inaccurate values. This was
removed to instead rely upon the existing `editorHasContent`
implementation found in the `PostEditor` class.

* build: Update GutenbergKit ref

* build: Update GutenbergKit ref

* build: Update GutenbergKit ref

* Update GutenbergKit ref

* Update GutenbergKit ref

---------

Co-authored-by: WordPress Mobile Bot Account <mobile+wpmobilebot@automattic.com>
Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
Co-authored-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>

* Fix an issue with comment selection state disappearing (#23658)

* Disable Reader anouncemnets (#23655)

* Fix an issue with Me header view alignment (#23647)

* Add Gutenberg Experimental Editor Switch (#23660)

* Add TipKit for Sidebar (#23648)

* Enable TipKit FF (#23661)

* Fix crash in TipKit (#23664)

* Update strings for localization

* Update app translations – `Localizable.strings`

* Bump version number

* Merge 25.4 release notes to `release/25.4` (#23672)

* Add editorialized release notes for version

* Update metadata strings

* Update metadata strings

---------

Co-authored-by: Automattic Release Bot <mobile+wpmobilebot@automattic.com>

* Remove ios_current_branch_is_hotfix from finalize_release

* Add options param to finalize_release lane

* Update app translations – `Localizable.strings`

* Update WordPress metadata translations

* Update Jetpack metadata translations

* Bump version number

* Add missing FeatureFlag.sidebar

* Resolve merge conflicts: Remove sidebar FF

The feature flag was removed on trunk: #23663

* Resolve merge conflicts: Remove duplicated code

The code was alrady merged into trunk: #23665

---------

Co-authored-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Co-authored-by: Ian Maia <ian.maia@automattic.com>
Co-authored-by: Gio Lodi <gio@mokacoding.com>
Co-authored-by: Tony Li <tony.li@automattic.com>
Co-authored-by: David Calhoun <github@davidcalhoun.me>
Co-authored-by: Gerardo <gerardo.pacheco@automattic.com>
Co-authored-by: Alex Grebenyuk <alex.grebenyuk@automattic.com>
Co-authored-by: Oguz Kocer <oguzkocer@users.noreply.github.com>
Co-authored-by: Oguz Kocer <oguz.kocer@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkmassel jkmassel jkmassel approved these changes

@crazytonyli crazytonyli Awaiting requested review from crazytonyli

Assignees
No one assigned
Labels
General
Projects
None yet
Milestone
25.4
Development

Successfully merging this pull request may close these issues.
4 participants
@kean @dangermattic @wpmobilebot @jkmassel