Improve post sharing in Reader

[kean]

Fixes #23685.

• Remove "title" and "summary" from the shared content
• Update Safari icon to use the modern one from SF symbols
• Remove the "Copy Link" action as "Copy" now does the same
• Make post title selectable (long-press to "Copy")

To test:

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[dangermattic]

	2 Warnings
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is assigned to the milestone 25.4.1. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23692-39373ec
	Version	25.4.1
	Bundle ID	org.wordpress.alpha
	Commit	39373ec
	App Center Build	WPiOS - One-Offs #10850

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23692-39373ec
	Version	25.4.1
	Bundle ID	com.jetpack.alpha
	Commit	39373ec
	App Center Build	jetpack-installable-builds #9892

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[dcalhoun]

Changes look sound to me. The functionality performed as expected when I tested them on an iPhone SE running iOS 18.0. 🚀

A few notes for future improvements in a separate PR:

• We might use the post title to populate fields in other apps—e.g., title in Reminders, subject in Mail.
• There is an odd animation that occurs in the menu located in the top-right corner when opening/closing the share sheet (video below).

Unexpected menu animation

ScreenRecording_10-24-2024.10-08-40_1.MP4

[dcalhoun]

Noting there are failing CI checks currently. Also, feel free to await further feedback from more experienced iOS developers, if you'd like.

[kean]

Thanks for the quick review!

We might use the post title to populate fields in other apps—e.g., title in Reminders, subject in Mail.

We are still using the title for this purpose:

        if let str = title {
            controller.setValue(str, forKey: "subject")
        }

When I test sharing to the Mail app, it does populate the subject.

Unexpected menu animation

I opened an issue #23694

Noting there are failing CI checks currently.

Got some flaky tests.

[dcalhoun]

When I test sharing to the Mail app, it does populate the subject.

Ah, good to hear.

I do not have Mail set up on my testing device, so I only tested Reminders and presumed Mail would also not function. When sharing to Reminders from the Jetpack app, the new entity name is "Reader." In contrast, Safari sets the new entity title to the post title. It could be that most other apps "just work" like your experience with Mail.

Jetpack	Safari

[kean]

I opened another ticket to track it #23695, thanks for the clarification