Skip to content

Conversation

@iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Oct 9, 2025

Closes AINFRA-1378: WPiOS: Validate that release version sent by ReleasesV2 matches the project

Description

This PR updates the code freeze process to use the release version provided by ReleasesV2 as the source of truth.

The code freeze Buildkite pipeline now passes the RELEASE_VERSION environment variable to the code_freeze Fastlane lane.
If there's a mismatch between the passed version and the project calculated version, a warning is displayed to help identify configuration discrepancies, but the ReleasesV2 version is always used.

Testing

The code freeze lane has several side effects like potentially changing the version in the main branch, creating a release branch, updating release notes, etc, making it hard to easily test it. We can run a couple of tests locally commenting out parts of the lane, but they'll only test a minor part of the lane.
The changes will then be fully tested in the next release cycle during code freeze.

@iangmaia iangmaia self-assigned this Oct 9, 2025
@iangmaia iangmaia added the Tooling Build, Release, and Validation Tools label Oct 9, 2025
@iangmaia iangmaia modified the milestones: 26.4 ❄️, 26.5 Oct 9, 2025
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 9, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number29459
VersionPR #24929
Bundle IDcom.jetpack.alpha
Commitf8a9245
Installation URL5o5rsemu5v298
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 9, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number29459
VersionPR #24929
Bundle IDorg.wordpress.alpha
Commitf8a9245
Installation URL104ovl1t85ju0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@AliSoftware
Copy link
Contributor

I have the same feedback as on https://github.com/bloom/DayOne-Android/pull/6612#pullrequestreview-3319847686, and given there's a batch of those PRs across repos, so let's focus the code review feedback on that single DOAndroid PR to avoid spreading the discussions, and merge the various repo's PRs all at once once the feedback have been addressed across all of them :)

@sonarqubecloud
Copy link

@iangmaia iangmaia added this pull request to the merge queue Oct 10, 2025
Merged via the queue into trunk with commit 7e60810 Oct 10, 2025
26 of 32 checks passed
@iangmaia iangmaia deleted the iangmaia/add-release-version-validation branch October 10, 2025 18:23
crazytonyli added a commit that referenced this pull request Nov 23, 2025
crazytonyli added a commit that referenced this pull request Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants