Move post revision related functions to Swift #25009
Merged
+91
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29904 | |
| Version | PR #25009 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | a04b449 | |
| Installation URL | 3l0uugu5pi8b0 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29904 | |
| Version | PR #25009 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | a04b449 | |
| Installation URL | 7s943l3q11rlo |
kean
reviewed
Nov 24, 2025
| /// True if the content field is empty, independent of the title field. | ||
| public func isContentEmpty() -> Bool { | ||
| let isContentAnEmptyGBParagraph = self.content == "<!-- wp:paragraph -->\n<p></p>\n<!-- /wp:paragraph -->" | ||
| return self.content != nil ? (self.content!.isEmpty || isContentAnEmptyGBParagraph) : true |
Contributor
There was a problem hiding this comment.
(nit) The implementation is not exactly idiomatic Swift. I'd probably do something like:
guard let content, !content.isEmpty else {
return true
}
return content == "<!-- wp:paragraph -->\n<p></p>\n<!-- /wp:paragraph -->"
The same applies to hasContent (force unwrap). They should both also probably be properties and not functions.
Contributor
Author
There was a problem hiding this comment.
I intentionally kept most of the Swift code similar to the original Objective-C code, so that we are more confident in the changes. But I don't mind rewriting some of the code if needed. Updated in a04b449.
crazytonyli
force-pushed
the
core-data-models-posts
branch
from
d8d279f to
a04b449
Compare
|
kean
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR will be merged after #25008.
Description
No feature changes, just translating ObjC to Swift. It's easier to review this PR commit by commit.