Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When inserting block from title replace block if appropriate #1227

Merged

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jul 13, 2019

Summary

Fixes an issue where inserting a block from the post title would not replace an empty paragraph block if that block was the first block in the post. Instead it would add a second empty paragraph block at the beginning of the post.

See related gutenberg PR for further detail and testing instructions

Update release notes:

I did not update the release notes because this seemed like a minor fix for an issue that was just introduced in 1.9, and which very few users would ever encounter. Just let me know if anyone thinks this should go in the release notes.

Release notes updated.

@mchowning mchowning changed the title Update gutenberg ref When inserting block from title replace block if appropriate Jul 13, 2019
@mchowning mchowning added this to the 1.10 milestone Jul 13, 2019
@mchowning mchowning self-assigned this Jul 13, 2019
@mchowning mchowning requested review from Tug and marecar3 July 13, 2019 01:52
@hypest
Copy link
Contributor

hypest commented Jul 15, 2019

Just let me know if anyone thinks this should go in the release notes.

I agree this issue is not major but, let's still mention it in the release notes so we can form the habit of updating the release notes when user facing changes happen.

@mchowning
Copy link
Contributor Author

let's still mention it in the release notes

Done!

Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Address fix for issue where inserting a block from the post title would not
replace an empty paragraph block if that block was the first block in the
post. Instead it would add a second empty paragraph block at the beginning
of the post.
@mchowning mchowning force-pushed the issue/632-replace-initial-empty-paragraph-block-from-title branch from f05fd1d to ba27f29 Compare July 19, 2019 23:44
@mchowning mchowning merged commit c96a3c5 into develop Jul 20, 2019
@mchowning mchowning deleted the issue/632-replace-initial-empty-paragraph-block-from-title branch July 20, 2019 00:20
@mchowning mchowning mentioned this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants