Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated "iOS Build" step from CircleCI to Buildkite #6134

Closed
wants to merge 53 commits into from
Closed

Duplicated "iOS Build" step from CircleCI to Buildkite #6134

wants to merge 53 commits into from

Commits on Aug 30, 2023

  1. Add "iOS Build" Buildkite job embryo: Only run npm on macOS 

    Notice I moved the other CI steps into a bak file to make iterating
faster.
    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d88a78a View commit details
    Browse the repository at this point in the history

  2. Fix automattic/nvm plugin version

    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ff613b4 View commit details
    Browse the repository at this point in the history

  3. Add environment setup and cmd to build app for testing

    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c0c49e0 View commit details
    Browse the repository at this point in the history

  4. Add cmd to build iOS bundle for E2E testing

    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ed14678 View commit details
    Browse the repository at this point in the history

  5. Zip artifact for SuaceLabs upload

    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    f7c662e View commit details
    Browse the repository at this point in the history

  6. Debug – Print IS_VM_HOST value

    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    f52d824 View commit details
    Browse the repository at this point in the history

  7. Bypass nvm plugin — Maybe it's not intended to work on macOS?

    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b8a3d01 View commit details
    Browse the repository at this point in the history

  8. Move logic to script to avoid forgetting to escape $ in pipeline

    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d488302 View commit details
    Browse the repository at this point in the history

  9. Debug – Remove IS_VM_HOST echo 

    It's unbound in the context of the `command` script. Besides, I already
learned what I needed from it.
    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    16ef716 View commit details
    Browse the repository at this point in the history

  10. Install Ruby version from react-native-editor

    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d054663 View commit details
    Browse the repository at this point in the history

  11. Debug – Hack CircleCI pipeline to force a rebuild 

    So I can see what it says in the log, given that it fails to code sign
on Buildkite.
    @mokagio
    mokagio committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a02a549 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Point gutenberg submodule to commit with changes for Buildkite

    @mokagio
    mokagio committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    a04bd80 View commit details
    Browse the repository at this point in the history

  2. Set custom -destination when building E2E iOS app in Buildkite

    @mokagio
    mokagio committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    e63b681 View commit details
    Browse the repository at this point in the history

  3. Revert "Debug – Hack CircleCI pipeline to force a rebuild" 

    This reverts commit a02a549.
    @mokagio
    mokagio committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    743cf1b View commit details
    Browse the repository at this point in the history

  4. Fix ZIP emoji in E2E Buildkite step. Priorities...

    @mokagio
    mokagio committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    6235f04 View commit details
    Browse the repository at this point in the history

  5. Move env var setting to script to have everything in one place

    @mokagio
    mokagio committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c563efc View commit details
    Browse the repository at this point in the history

  6. Add step to upload app to SauceLabs 🤞

    @mokagio
    mokagio committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    97b75de View commit details
    Browse the repository at this point in the history

  7. Fix setting x flag that was the wrong way around

    @mokagio
    mokagio committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    380f7df View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Use Gutenberg version with Ruby 2.7.4 

    Allows skipping the 2.7.5 install in CI
    @mokagio
    mokagio committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9215f0c View commit details
    Browse the repository at this point in the history

  2. Centralize Xcode version definition for Buildkite builds

    @mokagio
    mokagio committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5f9e2a3 View commit details
    Browse the repository at this point in the history

  3. Add step to test iOS canary

    @mokagio
    mokagio committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    cc807b1 View commit details
    Browse the repository at this point in the history

  4. Set SAUCE_FILENAME in tests step

    @mokagio
    mokagio committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8d93c76 View commit details
    Browse the repository at this point in the history

  5. Export CIRCLE_BRANCH in Buildkite to pass tests

    @mokagio
    mokagio committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    0162389 View commit details
    Browse the repository at this point in the history

  6. Parametrize test-ios.sh to run various test commands

    @mokagio
    mokagio committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9901f7a View commit details
    Browse the repository at this point in the history

  7. Make test-ios.sh executable 

    See the way
https://buildkite.com/automattic/gutenberg-mobile/builds/7086#018a4f59-89c9-4328-8a49-d07a4261a49a
failed
    @mokagio
    mokagio committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    17cf4e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Prevent unbound var

    @mokagio
    mokagio committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    693174f View commit details
    Browse the repository at this point in the history

  2. Fix emoji

    @mokagio
    mokagio committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    053a737 View commit details
    Browse the repository at this point in the history

  3. Add block step

    @mokagio
    mokagio committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    17fd291 View commit details
    Browse the repository at this point in the history

  4. Remove CircleCI configs for iOS build 

    This would have had to happen sooner or later as part of the migration
but the intent here is to see if the Buildkite tests still pass when
there's not CircleCI nor Buildkite "Build iOS" step running
    @mokagio
    mokagio committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    6af2820 View commit details
    Browse the repository at this point in the history

  5. Remove unused ios-device-checks command from CircleCI 

    Became unused in 6af2820
    @mokagio
    mokagio committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    58978cf View commit details
    Browse the repository at this point in the history

  6. Remove unused ios-build command from CircleCI 

    Became unused in 6af2820
    @mokagio
    mokagio committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    64f047a View commit details
    Browse the repository at this point in the history

  7. Add note about adding Slack reporting

    @mokagio
    mokagio committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    f8b581d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Restore building iOS for Sauce Labs before running the tests

    @mokagio
    mokagio committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    fcfe1d3 View commit details
    Browse the repository at this point in the history

  2. Add test failure annotation

    @mokagio
    mokagio committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    50dad0c View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @mokagio
    mokagio committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    eebf6c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Move depends-on to block step 

    Otherwise, the steps will ignore the block.
See https://buildkite.com/automattic/gutenberg-mobile/builds/7133
    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    488b6ef View commit details
    Browse the repository at this point in the history

  2. Switch back to trunk version of gutenberg

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    61890f8 View commit details
    Browse the repository at this point in the history

  3. Debug – Skip build again

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    8d9e683 View commit details
    Browse the repository at this point in the history

  4. See what happens adding depends after the depends in the block

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    5317ffb View commit details
    Browse the repository at this point in the history

  5. This should fix the block dependency

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d114cbd View commit details
    Browse the repository at this point in the history

  6. Test conditional behavior – 1/2: simulate trunk

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a2e16f3 View commit details
    Browse the repository at this point in the history

  7. DRY

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    0ff8dc7 View commit details
    Browse the repository at this point in the history

  8. Track result of running npm install 

    Possibly something I should have done after the Gutenberg sync in
61890f8
    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d0bc5d5 View commit details
    Browse the repository at this point in the history

  9. Test conditional behavior – 2/2: simulate trunk

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    597b69e View commit details
    Browse the repository at this point in the history

  10. Switch to Gutenberg version where tests should fail

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    524b1e4 View commit details
    Browse the repository at this point in the history

  11. Use proper condition for full vs quick UI tests branch filter

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    467230c View commit details
    Browse the repository at this point in the history

  12. Tweak pipeline organization and comments

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ae30923 View commit details
    Browse the repository at this point in the history

  13. Fix tests script not failing the build

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d97d1fc View commit details
    Browse the repository at this point in the history

  14. Restore build step

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    2d00b1c View commit details
    Browse the repository at this point in the history

  15. Restore full pipeline

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b1a3bd1 View commit details
    Browse the repository at this point in the history

  16. Update gutenberg to version that should fail in the build

    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    fa29c1b View commit details
    Browse the repository at this point in the history

  17. Use iPhone 14 as the Simulator destination 

    There is no iPhone 13 in our stock stack:
https://buildkite.com/automattic/gutenberg-mobile/builds/7164#018a695f-f47a-4488-9baf-6e554109722c/837-838
    @mokagio
    mokagio committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    f3b4039 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Point Gutenberg to WIP branch that does not fail on purpose

    @mokagio
    mokagio committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    713db36 View commit details
    Browse the repository at this point in the history