From 18e2f9d5b24106336a465b07fbe1d7392c9f6c8e Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Wed, 28 Jun 2023 13:26:49 -0400 Subject: [PATCH 1/7] docs: Remove duplicative Dark Mode Group block test case This test case is duplicative of the Group test case: https://github.com/wordpress-mobile/test-cases/blob/2389290ec634b25dcd19d1d2af3badcf8591ff4a/test-cases/gutenberg/group.md#tc009 --- test-cases/gutenberg/darkmode.md | 13 ------------- test-suites/gutenberg/functionality-test-suites.md | 1 - 2 files changed, 14 deletions(-) diff --git a/test-cases/gutenberg/darkmode.md b/test-cases/gutenberg/darkmode.md index f538b4d..c1ce935 100644 --- a/test-cases/gutenberg/darkmode.md +++ b/test-cases/gutenberg/darkmode.md @@ -62,19 +62,6 @@ Expected look: -------------------------------------------------------------------------------- -##### TC006 - -### Group Block - Check if in DarkMode all components gets proper colors - -- Add a `Group` block -- Check if `Group` block in Dark Mode looks like below - -Expected look: -![GroupDarkMode](../resources/group-dark-mode.png) -![GroupDarkModeEmpty](../resources/group-dark-mode-empty.png) - --------------------------------------------------------------------------------- - ##### TC008 ### Quote Block - Check if in DarkMode all components gets proper colors diff --git a/test-suites/gutenberg/functionality-test-suites.md b/test-suites/gutenberg/functionality-test-suites.md index 0b8b95c..30f93f5 100644 --- a/test-suites/gutenberg/functionality-test-suites.md +++ b/test-suites/gutenberg/functionality-test-suites.md @@ -187,7 +187,6 @@ This holds a grouping of certain test suites to run in order to share the work w - [ ] Spacer block - Dark mode - [TC004](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/darkmode.md#tc004) - [ ] Buttons block - Dark mode - [TC005](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/darkmode.md#tc005) -- [ ] Group - Dark mode - [TC006](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/darkmode.md#tc006) ### Group - 2 From 056e799b1c61a9a20ff2dede0685b8412e92193f Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Thu, 6 Jul 2023 15:37:36 -0400 Subject: [PATCH 2/7] docs: Remove automated Rich Text cases These were automated in https://github.com/WordPress/gutenberg/pull/49352. --- test-cases/gutenberg/writing-flow/readme.md | 9 -- .../writing-flow/rich-text-formatting.md | 86 ------------------- 2 files changed, 95 deletions(-) diff --git a/test-cases/gutenberg/writing-flow/readme.md b/test-cases/gutenberg/writing-flow/readme.md index 0b51a08..1c20c4b 100644 --- a/test-cases/gutenberg/writing-flow/readme.md +++ b/test-cases/gutenberg/writing-flow/readme.md @@ -9,16 +9,7 @@ - [ ] Code block (DEV only) - [ ] Pullquote block #### Rich Text Format -- [ ] [TC001](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc001) - Bold, Italic, strikethrough buttons -- [ ] [TC001](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc001) - Highlight selected text -- [ ] [TC001](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc001) - Highlight text without selection -- [ ] [TC002](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc002) - Alignment buttons -- [ ] [TC003](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc003) - Alignment Split -- [ ] [TC004](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc004) - Link button works without selection -- [ ] [TC005](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc005) - Link button works with a selected word -- [ ] [TC006](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc006) - Adding a link from a copied URL - [ ] [TC007](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc007) - Test format detection under the cursor -- [ ] [TC008](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc008) - Test formatting doesn't remove leading or trailing whitespace - [ ] [TC009](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc009) - Test autocorrection doesn't apply formatting to Heading - [ ] [TC010](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/rich-text-formatting.md#tc010) - Test autocorrection doesn't remove formatting from Heading ##### Splitting and merging diff --git a/test-cases/gutenberg/writing-flow/rich-text-formatting.md b/test-cases/gutenberg/writing-flow/rich-text-formatting.md index 6165963..a206019 100644 --- a/test-cases/gutenberg/writing-flow/rich-text-formatting.md +++ b/test-cases/gutenberg/writing-flow/rich-text-formatting.md @@ -5,82 +5,6 @@ Have a rich-text based component with content (Paragraph, Heading, Quote, Media Caption, etc...) -##### TC001 - -**Known Issues** - -- [Text color selection is not preserved when cursor is placed in the middle of text](https://github.com/WordPress/gutenberg/issues/42714) - -**Bold, Italic, strikethrough buttons** - -- Press the Bold button and write a bold word. -- Press the Italic button and write an italic word. -- Press strikethrough button and write strikethrough text. - -**Highlight selected text** - -- Write some text and select it. -- Tap on the Highlight text button (A). -- Select a color. -- Expect to see the text with the selected color. - -**Highlight text without selection** - -- Without selecting any text tap on the highlight text button (A). -- Select a color and write some text. -- Expect to see the newly introduced text with the previously selected color. - - -##### TC002 - -**Alignment buttons** - -- Press Left, Right, Center alignment buttons. -- Check that the text responds accordingly. - - -##### TC003 - -**Alignment Split** - -- Write some lines on a paragraph block. -- Set an alignment on the block. -- Move the caret by the half of the text and press enter to split it. -- Check that the new block has the same alignment. -- Check that the text alignment corresponds to the setting. - - -##### TC004 - -**Link button works without selection** - -- Press the links button -- Fill the options and dismiss to add a link. -- The link formatted word should be added to the block. - - -##### TC005 - -**Link button works with a selected word** - -- Write a word and select it. -- Press the link format button. -- Check that the `Link Text` field is pre-filled with the selected word. -- Add a URL and dismiss. -- The selected word now should be formatted as a link. - - -##### TC006 - -**Adding a link from a copied URL** - -- Go to a browser and copy a URL to the clipboard. -- Back to Gutenberg, select a word on a rich-text based component. -- Press the Link format button. -- Check that the copied URL is pre-filled on the URL field. -- Dismiss the bottom-sheet to see the selected word formatted as a link. - - ##### TC007 **Test format detection under the cursor** @@ -89,16 +13,6 @@ Have a rich-text based component with content (Paragraph, Heading, Quote, Media Move the cursor around - Check that the proper format buttons get selected when the cursor get under a formatted word. - -##### TC008 - -**Test formatting doesn't remove leading or trailing whitespace** - -- Add a text-based block, paragraph for example -- Type some spaces, then write some text, then type some more spaces -- Select the _text_ and apply one format, for example, bold -- Check that the leading and trailing spaces aren't removed - ##### TC009 **Test autocorrection doesn't apply formatting to Heading** From 585aa7c7bf7643307d1d9f155f13621810389834 Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Thu, 6 Jul 2023 15:48:29 -0400 Subject: [PATCH 3/7] docs: Remove automated List splitting and merging test This was automated in https://github.com/WordPress/gutenberg/pull/45048. --- test-cases/gutenberg/writing-flow/readme.md | 1 - .../gutenberg/writing-flow/splitting-merging.md | 17 ----------------- 2 files changed, 18 deletions(-) diff --git a/test-cases/gutenberg/writing-flow/readme.md b/test-cases/gutenberg/writing-flow/readme.md index 1c20c4b..6becd55 100644 --- a/test-cases/gutenberg/writing-flow/readme.md +++ b/test-cases/gutenberg/writing-flow/readme.md @@ -28,7 +28,6 @@ - [ ] [TC005](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/splitting-merging.md#tc005) - Merge multiple blocks - [ ] Paragraph - [ ] Heading -- [ ] [TC006](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/splitting-merging.md#tc006) - Splitting/merge list block #### Undo / Redo - Test Cases - [ ] [TC001](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/undo-redo.md#tc001) - Undo/redo block actions - [ ] [TC002](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/undo-redo.md#tc002) - Undo/redo text diff --git a/test-cases/gutenberg/writing-flow/splitting-merging.md b/test-cases/gutenberg/writing-flow/splitting-merging.md index f8caff0..a228c2f 100644 --- a/test-cases/gutenberg/writing-flow/splitting-merging.md +++ b/test-cases/gutenberg/writing-flow/splitting-merging.md @@ -75,20 +75,3 @@ Start from an empty post. - Press enter two times to create an empty block in between - Press back two times to merge everything again. - Check that the blocks were merged. - - -##### TC006 - -**Splitting/merge list block** - -- Write some items on a list block -- Put the caret by the half of them (at the end of the item) and press Enter to create a new item. -- Press Enter again to split the block into two, with an empty paragraph block in the middle. The paragraph block at the middle should be focused. -- Write something on that newly created paragraph block. -- Move the cursor to the beginning of the paragraph block -- Press delete to merge the paragraph block with the upper list block. -- Check that the new word should be a new list item. -- Move the caret to the beginning of the second list block. -- Press delete once to merge it back into the first list block. -- Check that everything was merged and there’s just one list block. - From 9f248b3c86ec53a3093ad7c159c3174b0637320b Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Thu, 6 Jul 2023 15:51:31 -0400 Subject: [PATCH 4/7] docs: Remove automated undo and redo test cases These were automated in https://github.com/WordPress/gutenberg/pull/49352. --- test-cases/gutenberg/writing-flow/readme.md | 2 -- .../gutenberg/writing-flow/undo-redo.md | 24 ------------------- 2 files changed, 26 deletions(-) diff --git a/test-cases/gutenberg/writing-flow/readme.md b/test-cases/gutenberg/writing-flow/readme.md index 6becd55..34c808f 100644 --- a/test-cases/gutenberg/writing-flow/readme.md +++ b/test-cases/gutenberg/writing-flow/readme.md @@ -29,6 +29,4 @@ - [ ] Paragraph - [ ] Heading #### Undo / Redo - Test Cases -- [ ] [TC001](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/undo-redo.md#tc001) - Undo/redo block actions - [ ] [TC002](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/undo-redo.md#tc002) - Undo/redo text -- [ ] [TC003](https://github.com/wordpress-mobile/test-cases/blob/trunk/test-cases/gutenberg/writing-flow/undo-redo.md#tc003) - Undo/redo text format diff --git a/test-cases/gutenberg/writing-flow/undo-redo.md b/test-cases/gutenberg/writing-flow/undo-redo.md index 55388c8..c0d1457 100644 --- a/test-cases/gutenberg/writing-flow/undo-redo.md +++ b/test-cases/gutenberg/writing-flow/undo-redo.md @@ -5,15 +5,6 @@ Start on a new empty post. -##### TC001 - -**Undo/redo block actions** - -- From the example app, remove a few blocks. -- Press the Undo button to see them reappear. -- Press Redo to remove the blocks again. - - ##### TC002 **Known Issues** @@ -26,18 +17,3 @@ Start on a new empty post. - Write some text on a text based block . - Press Undo until all new text has disappeared. - Press Redo to see the text appear again. - - -##### TC003 - -**Known Issues** - -- Highlighting text breaks the ability to redo changes. [#38084](https://github.com/WordPress/gutenberg/issues/38084) - -**Undo/redo text format** - -- On a rich-text based component, add some format (bold, links, etc…). -- Undo all changes and Redo them to arrive to the same state. - - - From 46262fe11c8443eee0a23029e61be55f9ae2000a Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Sat, 8 Jul 2023 08:30:44 -0400 Subject: [PATCH 5/7] docs: Remove automated undo and redo test case These were automated in https://github.com/WordPress/gutenberg/pull/49352. This test was left in place due to the known issues, but there is little value in doing so. The known issues are capture as individual issues in GitHub. https://github.com/wordpress-mobile/test-cases/pull/147/files#r1255412693 --- .../gutenberg/writing-flow/undo-redo.md | 19 ------------------- 1 file changed, 19 deletions(-) delete mode 100644 test-cases/gutenberg/writing-flow/undo-redo.md diff --git a/test-cases/gutenberg/writing-flow/undo-redo.md b/test-cases/gutenberg/writing-flow/undo-redo.md deleted file mode 100644 index c0d1457..0000000 --- a/test-cases/gutenberg/writing-flow/undo-redo.md +++ /dev/null @@ -1,19 +0,0 @@ - -# Undo / Redo - Test Cases - -#### **Precondition** - -Start on a new empty post. - -##### TC002 - -**Known Issues** - -- Undoing the insertion of characters can result in the cursor being misplaced. [#303](https://github.com/wordpress-mobile/gutenberg-mobile/issues/303) -- It is not possible to redo changes after redoing the insertion of an image into an image block. [#2499](https://github.com/wordpress-mobile/gutenberg-mobile/issues/2499) - -**Undo/redo text** - -- Write some text on a text based block . -- Press Undo until all new text has disappeared. -- Press Redo to see the text appear again. From 39092ca7bc936df3343d29b32f1dd8c9c885e250 Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Sat, 8 Jul 2023 13:47:32 -0400 Subject: [PATCH 6/7] test: Reinstate text highlight without selection Our `typeInRichText` integration helper does not support parsing inner HTML tags. This is required in order to type at the correct cursor position, i.e. with the cursor placed within the `mark` tag that applies the text highlighting. Adding support for this gets complicated quickly, e.g. how might we support typing with a text selection the begins within a tag but finishes outside of it? Instead, adding an e2e test is likely the best approach. --- .../gutenberg/writing-flow/rich-text-formatting.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test-cases/gutenberg/writing-flow/rich-text-formatting.md b/test-cases/gutenberg/writing-flow/rich-text-formatting.md index a206019..aa7e64a 100644 --- a/test-cases/gutenberg/writing-flow/rich-text-formatting.md +++ b/test-cases/gutenberg/writing-flow/rich-text-formatting.md @@ -5,6 +5,17 @@ Have a rich-text based component with content (Paragraph, Heading, Quote, Media Caption, etc...) +##### TC001 + +**Known Issues** + +- [Text color selection is not preserved when cursor is placed in the middle of text](https://github.com/WordPress/gutenberg/issues/42714) + +**Highlight text without selection** + +- Without selecting any text tap on the highlight text button (A). +- Select a color and write some text. +- Expect to see the newly introduced text with the previously selected color. ##### TC007 **Test format detection under the cursor** From 644026351243da07d3f40e0aff3d98d3407ccf6a Mon Sep 17 00:00:00 2001 From: David Calhoun Date: Mon, 10 Jul 2023 08:43:32 -0400 Subject: [PATCH 7/7] docs: Reinstate line break between test cases --- test-cases/gutenberg/writing-flow/rich-text-formatting.md | 1 + 1 file changed, 1 insertion(+) diff --git a/test-cases/gutenberg/writing-flow/rich-text-formatting.md b/test-cases/gutenberg/writing-flow/rich-text-formatting.md index aa7e64a..87f1840 100644 --- a/test-cases/gutenberg/writing-flow/rich-text-formatting.md +++ b/test-cases/gutenberg/writing-flow/rich-text-formatting.md @@ -16,6 +16,7 @@ Have a rich-text based component with content (Paragraph, Heading, Quote, Media - Without selecting any text tap on the highlight text button (A). - Select a color and write some text. - Expect to see the newly introduced text with the previously selected color. + ##### TC007 **Test format detection under the cursor**