Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo mock_write_url file copy effects in patch context manager #18

Open
robinsonkwame opened this issue Jan 30, 2018 · 1 comment
Open

Undo mock_write_url file copy effects in patch context manager #18

robinsonkwame opened this issue Jan 30, 2018 · 1 comment
Labels
enhancement

Comments

@robinsonkwame
Copy link
Member

The test_etl.py (as of writing) uses a context manager to patch etl.vt.CCARSJobsPostings.write_url but since it's a mock patch manager, it does not call the method undo_mock_write_url, which removes the copied test file, to avoid side effects. A new patch manager should be made (or extended) to also call self.undo_mock_write_url
@robinsonkwame
Copy link
Member Author

note this is done in test_candidate_skills.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robinsonkwame